Fix ELC sample #3468
Merged
Fix ELC sample #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script was not correct. The ELC method requires a gap region with solid walls to block periodicity along the z-direction.
This recycles the recently deleted visualization_mmm2d.py sample.
This recycles the recently deleted documentation for MMM2D.
Move documentation of class constructor arguments from the reSt files to the corresponding classes docstrings in electrostatics and magnetostatics methods. Add links to Python classes in reSt files and add links to reSt files in the Python docstrings.
|
This could be reviewed by @biermanncarl. |
Codecov Report
@@ Coverage Diff @@
## python #3468 +/- ##
=======================================
+ Coverage 86% 86% +<1%
=======================================
Files 537 537
Lines 24730 24659 -71
=======================================
- Hits 21340 21333 -7
+ Misses 3390 3326 -64
Continue to review full report at Codecov.
|
biermanncarl
approved these changes
Feb 11, 2020
fweik
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3453
Description of changes: