LB function signature

[KaiSzuttor]

@pkreissl likes bool more than int

[pkreissl]

The Checkpointing LB section of the sphinx documentation (in lb.rst) has to be updated, basically doing two replacements (binary=0 and binary=1 to the respective bool).

[RudolfWeeber]

On Tue, Feb 25, 2020 at 02:30:08AM -0800, Kai Szuttor wrote: @pkreissl likes bool more than int

I'd prefer not merging not-so-critical changes into LB to reduce merge conflicts with the Walberla branch. This PR might fall into that category.

[codecov]

Codecov Report

Merging #3541 into python will increase coverage by <1%.
The diff coverage is 96%.

@@           Coverage Diff            @@
##           python   #3541     +/-   ##
========================================
+ Coverage      87%     87%    +<1%     
========================================
  Files         536     513     -23     
  Lines       24177   22313   -1864     
========================================
- Hits        21058   19566   -1492     
+ Misses       3119    2747    -372

Impacted Files	Coverage Δ
src/script_interface/constraints/initialize.cpp	100% <ø> (ø)	⬆️
...terface/virtual_sites/ActiveVirtualSitesHandle.hpp	100% <ø> (ø)	⬆️
...c/core/unit_tests/ParallelScriptInterface_test.cpp	100% <ø> (ø)	⬆️
src/core/io/writer/h5md_core.hpp	53% <ø> (ø)	⬆️
...ce/observables/CylindricalPidProfileObservable.hpp	13% <ø> (ø)	⬆️
...pt_interface/cluster_analysis/ClusterStructure.hpp	97% <ø> (ø)	⬆️
src/core/unit_tests/Variant_test.cpp	100% <ø> (ø)	⬆️
src/script_interface/shapes/Ellipsoid.hpp	83% <ø> (ø)	⬆️
src/core/EspressoSystemInterface.cpp	40% <ø> (-52%)	⬇️
src/script_interface/cluster_analysis/Cluster.hpp	94% <ø> (ø)	⬆️
... and 252 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d82c8d4...08315b1. Read the comment docs.

[pkreissl]

On Tue, Feb 25, 2020 at 02:30:08AM -0800, Kai Szuttor wrote: @pkreissl likes bool more than int
I'd prefer not merging not-so-critical changes into LB to reduce merge conflicts with the Walberla branch. This PR might fall into that category.

I get the point. This PR, however, only makes the signature of the lb load/save checkpoint functions consistent with the rest of the interface (see issue #1942) – as far as I understand it, this should not conflict with waLBerla integration. If I am wrong, feel free to close this PR.

[jngrad]

We could merge it in 4.1.3 only.

[KaiSzuttor]

@RudolfWeeber

[fweik]

@jngrad I think this should be merged and the trivial patch also applied to the walberla branch.