Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation params #3559

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Rotation params #3559

merged 2 commits into from
Mar 3, 2020

Conversation

KaiSzuttor
Copy link
Member

Fixes #3550

Description of changes:

  • fixing utils function rotation_params that returned wrong results if the input vector's norm was not unity

@KaiSzuttor KaiSzuttor requested a review from fweik March 3, 2020 11:08
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #3559 into python will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3559    +/-   ##
=======================================
+ Coverage      87%     87%   +<1%     
=======================================
  Files         525     525            
  Lines       23693   23720    +27     
=======================================
+ Hits        20789   20815    +26     
- Misses       2904    2905     +1
Impacted Files Coverage Δ
...rc/shapes/unit_tests/HollowConicalFrustum_test.cpp 100% <100%> (ø) ⬆️
src/utils/include/utils/math/vec_rotate.hpp 100% <100%> (ø) ⬆️
src/utils/tests/vec_rotate_test.cpp 100% <100%> (ø) ⬆️
src/core/particle_data.cpp 96% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cdcb86...ae20e4f. Read the comment docs.

@fweik
Copy link
Contributor

fweik commented Mar 3, 2020

LGTM when you made it work with the minimal required version of boost.

@KaiSzuttor KaiSzuttor added the automerge Merge with kodiak label Mar 3, 2020
maintainer: fix shape test and vec_rotate test.
@kodiakhq kodiakhq bot merged commit 24363da into espressomd:python Mar 3, 2020
@jngrad jngrad added this to the Espresso 4.1.3 milestone Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HollowConicalFrustum's orientation does not align with its axis parameter
3 participants