Remove MPI static globals #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 5, 2024
https://build.opensuse.org/request/show/1144047 by user cjunghans + anag+factory - Fix undefined behavior due to improper handling of MPI static globals - Add mpi.patch to remove MPI globals (gh#espressomd/espresso#4858)
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 7, 2024
https://build.opensuse.org/request/show/1144047 by user cjunghans + anag+factory - Fix undefined behavior due to improper handling of MPI static globals - Add mpi.patch to remove MPI globals (gh#espressomd/espresso#4858)
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 7, 2024
https://build.opensuse.org/request/show/1144047 by user cjunghans + anag+factory - Fix undefined behavior due to improper handling of MPI static globals - Add mpi.patch to remove MPI globals (gh#espressomd/espresso#4858)
This reverts commit f4590fd.
All MPI-related static global variables were removed, replaced by non-owning pointers, or replaced by owning pointers that are reset at normal program termination. Objects that need a MPI environment during destruction (FFT MPI plans, parallel file writers, etc.) now keep a shared pointer to the MPI environment. MpiCallbacks unit tests now call `MpiCallbacks::loop()` on worker nodes to avoid a non-empty receive queue at destruction of the MPI environment (fatal error in MPICH 4.1+).
jngrad
force-pushed
the
boost_mpi_bugfix
branch
from
caf7fda
to
5776a20
Compare
|
Bugfix backported to 4.2.1 and submitted to stable by Bohdi as espresso-4.2.1-11.fc41. |
reinaual
approved these changes
Feb 29, 2024
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Feb 29, 2024
Fixes espressomd#4856 Description of changes: - fix multiple bugs caused by undefined behavior due to the static initialization order of MPI global objects - ESPResSo is now compatible with Boost 1.84+
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Feb 29, 2024
Fixes espressomd#4856 Description of changes: - fix multiple bugs caused by undefined behavior due to the static initialization order of MPI global objects - ESPResSo is now compatible with Boost 1.84+
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Feb 29, 2024
Fixes espressomd#4856 Description of changes: - fix multiple bugs caused by undefined behavior due to the static initialization order of MPI global objects - ESPResSo is now compatible with Boost 1.84+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4856
Description of changes: