Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MPI static globals #4858

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Remove MPI static globals #4858

merged 2 commits into from
Feb 29, 2024

Commits on Feb 27, 2024

  1. Revert "Restrict Boost range" 

    This reverts commit f4590fd.
    @jngrad
    jngrad committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c87f89f View commit details
    Browse the repository at this point in the history

  2. Fix several occurrences of undefined behavior 

    All MPI-related static global variables were removed, replaced by
non-owning pointers, or replaced by owning pointers that are reset
at normal program termination. Objects that need a MPI environment
during destruction (FFT MPI plans, parallel file writers, etc.)
now keep a shared pointer to the MPI environment. MpiCallbacks
unit tests now call `MpiCallbacks::loop()` on worker nodes to avoid
a non-empty receive queue at destruction of the MPI environment
(fatal error in MPICH 4.1+).
    @jngrad
    jngrad committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5776a20 View commit details
    Browse the repository at this point in the history