From 4c3e52c6e5bcc82500c060d5cbdd6e1b77584fec Mon Sep 17 00:00:00 2001 From: Han Kang Date: Mon, 5 Jun 2023 16:47:19 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Benjamin Wang Signed-off-by: Han Kang Change-Id: I45fda0a8ee7d80638af96fee4efb3bfdf2aebaf8 --- server/etcdserver/api/etcdhttp/health.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/server/etcdserver/api/etcdhttp/health.go b/server/etcdserver/api/etcdhttp/health.go index 74224c1e4e0..66222241651 100644 --- a/server/etcdserver/api/etcdhttp/health.go +++ b/server/etcdserver/api/etcdhttp/health.go @@ -67,8 +67,7 @@ func HandleLivez(lg *zap.Logger, mux *http.ServeMux, srv ServerHealth) { if h := checkAlarms(lg, srv, excludedAlarms, endpoint); h.Health != "true" { return h } - // TODO(logicalhan) should we require quorum for livez? - return checkAPI(lg, srv, serializable) + return checkAPI(lg, srv, true) }, PathLivez, []string{etcdserverpb.AlarmType_NOSPACE.String()}...)) } @@ -79,7 +78,7 @@ func HandleReadyz(lg *zap.Logger, mux *http.ServeMux, srv ServerHealth) { if h := checkAlarms(lg, srv, excludedAlarms, endpoint); h.Health != "true" { return h } - return checkAPI(lg, srv, serializable) + return checkAPI(lg, srv, false) }, PathReadyz)) }