Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve comments for clientv3test.TestUnresolvableOrderViolation #16865

Closed
lavacat opened this issue Nov 5, 2023 · 3 comments
Closed

Improve comments for clientv3test.TestUnresolvableOrderViolation #16865

lavacat opened this issue Nov 5, 2023 · 3 comments
Assignees
@shaoqin2
Labels
area/testing contribfest Issues for Contribfest workshop happening during KubeCon stale type/cleanup

Comments

@lavacat
Copy link

lavacat commented Nov 5, 2023

What would you like to be added?

Please review the test and provide summary at the beginning of the test, so it's clear what and how we are testing.

Why is this needed?

improving readability
@lavacat lavacat added area/testing contribfest Issues for Contribfest workshop happening during KubeCon labels Nov 5, 2023
@jmhbnz jmhbnz mentioned this issue Nov 5, 2023
Closed
2 tasks
@shaoqin2
Copy link
Contributor

shaoqin2 commented Nov 7, 2023

From Kubecon contribfest: I can take a look at this one

@lavacat lavacat assigned lavacat and shaoqin2 and unassigned lavacat Nov 7, 2023
@shaoqin2 shaoqin2 mentioned this issue Nov 11, 2023
Merged
@stale Stale
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
@jmhbnz
Copy link
Member

jmhbnz commented Mar 31, 2024

Closed, was completed in #16920

@jmhbnz jmhbnz closed this as completed Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaoqin2 shaoqin2

Labels
area/testing contribfest Issues for Contribfest workshop happening during KubeCon stale type/cleanup
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lavacat @shaoqin2 @jmhbnz