Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate github workflows with Kubernetes Bot commands #16956

Closed
serathius opened this issue Nov 16, 2023 · 2 comments · Fixed by #16965
Closed

Integrate github workflows with Kubernetes Bot commands #16956

serathius opened this issue Nov 16, 2023 · 2 comments · Fixed by #16965
Assignees
@ivanvc
Labels
area/testing area/tooling good first issue help wanted type/feature

Comments

@serathius
Copy link
Member

What would you like to be added?

Copy https://github.com/kubernetes-sigs/metrics-server/blob/master/.github/workflows/gh-workflow-approve.yaml to etcd project allowing /ok-to-test command to also work with github workflows.

Why is this needed?

Allow etcd members to trigger tests on PRs from new contributors and possibly more in the future
@ivanvc
Copy link
Member

ivanvc commented Nov 16, 2023

Can you assign this to me? Thanks

@jmhbnz jmhbnz mentioned this issue Nov 16, 2023
Merged
@ivanvc ivanvc mentioned this issue Nov 17, 2023
Merged
@ivanvc
Copy link
Member

ivanvc commented Nov 17, 2023

I implemented this on #16965, which works for the main branch. Do we want to enable/implement this for the release-3,5 (or other) branch?

This was referenced Dec 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanvc ivanvc

Labels
area/testing area/tooling good first issue help wanted type/feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

github workflow: enable workflow approval ivanvc/etcd
3 participants
@ivanvc @serathius @jmhbnz