Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Input: Accidental function in ERC-223 #283

Closed
SamWilsn opened this issue Oct 17, 2023 · 6 comments
Closed

Call for Input: Accidental function in ERC-223 #283

SamWilsn opened this issue Oct 17, 2023 · 6 comments

Comments

@SamWilsn
Copy link
Collaborator

Decision

Will we merge ethereum/EIPs#7856? See that pull request for details.

Method Rough Consensus
Deadline November 16, 2023

tl;dr function was removed from spec then later accidentally re-added.

@SamWilsn
Copy link
Collaborator Author

I don't see a problem with this. Like @Pandapip1 says, removing this function is backwards compatible and this definitely looks like a mistake on the authors' part.


merge

@Pandapip1
Copy link
Contributor

+1 for me. Will also assist @Dexaran if he wants to seperate this into its own standard as-is.

@xinbenlv
Copy link

I thought the ERC-223 is... final?

@g11tech
Copy link

g11tech commented Oct 18, 2023

i am fine removing something which accidentally got by and already notifies in EIP that implementations shouldn't depend on it

@poojaranjan poojaranjan mentioned this issue Oct 18, 2023
11 tasks
@xinbenlv
Copy link

xinbenlv commented Oct 18, 2023

I am fine to have it removed if it's accidental inclusion provided it's still very recently finalized. And let's avoid this next time together.

@bumblefudge
Copy link

cut-and-dry example of an "errata" edit-- not a normative change, doesn't break anything normative, grounded in the history of the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants