Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got "missing r" error when using EAS + Metamask + etherjs #97

Open
xiaohou77 opened this issue May 13, 2024 · 11 comments
Open

Got "missing r" error when using EAS + Metamask + etherjs #97

xiaohou77 opened this issue May 13, 2024 · 11 comments

Comments

@xiaohou77
Copy link

Issue detail

In our dApp https://app.fairsharing.xyz/, when we make an onchain attestaion call, metamask returned the error as below snapshot,

We use EAS + Metamask + etherjs. When we change wallet app to like OKX, it works well.

image

Who should fix this issue and how?

I found a relative issue ethers-io/ethers.js#3926, seems we have to wait for etherjs to fix?
Or metamask should get this fixed?

Or we have to replace etherjs?

Please help look into this issue, it is blocking many users using our dApp now.

@brycealan @slavik0329

@AmazingAng
Copy link

We have met a similat issue recently. This seems related to recent metamask upgrade.

@RutenisN
Copy link

We have same issues, upgraded to ethers 6.9.0 it seemed to have fixed it, but after a few days I encountered same issue again so it's not consistent. Whats the solution? Whats causing this? Thanks.

@lbeder
Copy link
Member

lbeder commented May 14, 2024

It seems to be caused by Metamask or WalletConnect's latest upgrades. They are working on a fix, so hopefully it will be resolved soon.

@miguelCyclone
Copy link

Any updated on this?

@lbeder
Copy link
Member

lbeder commented May 25, 2024

Any updated on this?

No, unfortunately. Does this still reproduce with the latest MetaMask?

@DloomPlz
Copy link

I also encounter the same issue while deploying a contract with "ethers": "^6.8.1" and metamask extension at this date.

Uncaught (in promise) TypeError: missing r ...

@lbeder
Copy link
Member

lbeder commented May 26, 2024

I also encounter the same issue while deploying a contract with "ethers": "^6.8.1" and metamask extension at this date.

Uncaught (in promise) TypeError: missing r ...

Which contract?

@DloomPlz
Copy link

DloomPlz commented May 26, 2024

A custom factory contract, which is not related to eas at all

@itev4n7
Copy link

itev4n7 commented Jun 4, 2024

also have the same issue using "ethers": "6.7.0", "hardhat": "2.22.4" and MetaMask 11.15.6
but anyway transaction is success even with this error on local hardhat node
Screenshot 2024-06-04 at 13 55 09

Updated: find out solution for me is to use
import { ethers } from "https://cdnjs.cloudflare.com/ajax/libs/ethers/6.13.0/ethers.min.js";
for my web app

@xiaohou77 So try to use "ethers": "6.13.0"

@lbeder
Copy link
Member

lbeder commented Jun 4, 2024

@itev4n7 please make sure to post it on Metamask's and ether's repos as well. This issue is unrelated to EAS.

@xiaohou77
Copy link
Author

I have submitted a issue on MetaMask repo: MetaMask/metamask-extension#25032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants