Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo: Node 22 Support #3644

Closed
holgerd77 opened this issue Sep 9, 2024 · 4 comments
Closed

Monorepo: Node 22 Support #3644

holgerd77 opened this issue Sep 9, 2024 · 4 comments
Labels
effort: E1 hours package: monorepo target: maintenance-v8 Work to be done towards maintenance-v8 branch target: master Work to be done towards master branch type: CI

Comments

@holgerd77
Copy link
Member

Node.js 22 has been released quite some months ago (April 2024) as is soon becoming the active LTS release (end of October, see release matrix).

Before we do the breaking releases we should definitely add this to the Node versions workflow and do eventual fixes.

Maybe it's also time to switch our normal CI runs to use Node.js 22 as default (guess we'll want here the "currently most poplar version" [tm] (at least roughly following).

And lastly I think we should also add Node.js 22 support to the maintenance-v8 branch, we'll still be supporting this for some couple of months and so it would make sense to give this some love from this side as well.

@holgerd77 holgerd77 added effort: E1 hours type: CI package: monorepo target: master Work to be done towards master branch target: maintenance-v8 Work to be done towards maintenance-v8 branch labels Sep 9, 2024
@gabrocheleau
Copy link
Contributor

I think as a guideline, it would make sense to always stick with the "Active" LTS version. It also matches with what Node recommends in their docs:
"Production applications should only use Active LTS or Maintenance LTS releases."

By staying up-to-date with the Active, then we give ourselves a maintenance buffer to update our codebase if there are breaking changes that require significant updates on our side.

@holgerd77
Copy link
Member Author

Yeah, that makes sense, I just wonder in this particular case: does it make sense to switch 1-2 months "too early" just for practical reasons, so when we are adding Node 22 anyhow and this can be done along (and we normally just "never" [tm] get this "to the point" (so, switching 1-3 weeks around the active switch date) anyhow).

(I would cautiously vote for "let's just directly switch", but absolutely no strong opinion)

@ScottyPoi
Copy link
Contributor

Started working on this. Turns out our "node versions" workflow was not actually testing different versions 🤔

@holgerd77
Copy link
Member Author

Closed by #3669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: E1 hours package: monorepo target: maintenance-v8 Work to be done towards maintenance-v8 branch target: master Work to be done towards master branch type: CI
Projects
None yet
Development

No branches or pull requests

3 participants