Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload progress for Nodejs #397

Closed
AuHau opened this issue Aug 23, 2021 · 2 comments
Closed

Upload progress for Nodejs #397

AuHau opened this issue Aug 23, 2021 · 2 comments

Comments

@AuHau
Copy link
Contributor

AuHau commented Aug 23, 2021

It should be possible to stream the upload on NodeJS side and wrap that stream with Passthrough stream to track how much was already uploaded. With this we could have a progress tracking support.

A question is how to communicate this to the user that it is possible only on NodeJS? Maybe to use similar concept like data.ts vs data.browser.ts?

@agazso
Copy link
Member

agazso commented Aug 23, 2021

I think the most important is to emphasize in the documentation. Then depending on the implementation we may ignore the parameter for the progress tracking or throw an error when used in the browser.

@AuHau
Copy link
Contributor Author

AuHau commented Oct 4, 2021

Currently, the upload progress is "supported" with work-around presented in the example https://github.com/ethersphere/examples-js/tree/master/upload-progress

@AuHau AuHau closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants