Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Tab→" note on autocompletion entries #70

Closed
LoganDark opened this issue Feb 17, 2019 · 11 comments · Fixed by #278
Closed

Add "Tab→" note on autocompletion entries #70

LoganDark opened this issue Feb 17, 2019 · 11 comments · Fixed by #278
Labels

Comments

@LoganDark
Copy link
Contributor

Imagine this:

Type h. You see help, but you want history. Down arrow to select history, review the description, looks good. Right arrow... doesn't autocomplete, nothing happens. That's okay... clicking on the item also does nothing... Well heck, now I have to type a whole 5 letters. This is definitely not okay.

:)

@evaera
Copy link
Owner

evaera commented Feb 17, 2019

You should press Tab to auto-complete, not right arrow. Perhaps right arrow could be added as an alternative in addition to Tab.

@LoganDark
Copy link
Contributor Author

LoganDark commented Feb 17, 2019

And don't forget clicking on the item directly. I got extremely confused when even that didn't work. Perhaps you could add a footnote at the bottom of the autocomplete frame, "Tab to autocomplete"

@evaera
Copy link
Owner

evaera commented Feb 17, 2019

I'm not too sure on the clicking, since Cmdr is solely a keyboard experience right now. I think I'd rather hold off on making them buttons until if/when Cmdr receives an update to make it compatible with touch interfaces.

@LoganDark
Copy link
Contributor Author

LoganDark commented Feb 17, 2019

I wasn't aiming for it not to be a keyboard experience, however some kind of footnote or right-arrow completion (as my actual shell supports) would be nice.

@evaera
Copy link
Owner

evaera commented Feb 17, 2019

Actually, I don't think it would be possible to support right-arrow completion since there is no way to determine what the user's cursor position is inside a TextBox at any given moment. Thus it would be impossible to distinguish if the user was auto-completing or just moving their cursor to the right.

@LoganDark
Copy link
Contributor Author

Footnote then?

@evaera
Copy link
Owner

evaera commented Feb 17, 2019

Sure, I imagine it looking like this: (without the outline...)
image

@evaera evaera changed the title Clicking on autocomplete items, using right arrow, etc... don't work Add "Tab→" note on autocompletion entries Feb 17, 2019
@evaera evaera added the type:enhancement New feature or request label Feb 17, 2019
@LoganDark
Copy link
Contributor Author

LoganDark commented Feb 17, 2019

image

IMHO this one looks better, but provides slightly less indication on which one will be completed

@LoganDark
Copy link
Contributor Author

LoganDark commented Feb 17, 2019

Here's a graphic, if you'd like.

slice

Should be resized to 30 pixels tall, I've provided it at 2x resolution for Retina support.

Okay, the graphic is not a good idea. Even with the correct text size, it looks out of place.

Maybe use a TextLabel with the same Code font?

@evaera
Copy link
Owner

evaera commented May 7, 2019

Note that it's now possible to add support for right arrow completion, as the CursorPosition property has been added to text boxes.

@LoganDark
Copy link
Contributor Author

Yeeeeeeeesssssssss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants