You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Node 12 added some limited support for async stack traces. I'm impressed that this package supports them, but it removes a useful annotation from them:
The stack traces without registering source-map-support is:
Error
at f (/private/tmp/async-stack-traces/index.js:9:9)
at async main (/private/tmp/async-stack-traces/index.js:13:3)
With source-map-support registered is:
Error:
at f (/private/tmp/async-stack-traces/index.js:9:9)
at main (/private/tmp/async-stack-traces/index.js:13:3)
I think the async annotation there is useful, as this stack trace is not the actual one as seen by v8, but an augmented one. This augmentation doesn't always work, and it would be surprising to the user if they look like normal stack traces.
The text was updated successfully, but these errors were encountered:
Can confirm, this is super confusing as I wasn't sure what was causing it and I wasn't sure if my stack traces were actually working. Several hours later I found this issue.
To fix this, the implementation of CallSiteToString -- which is copy-pasted from V8 source code -- must be updated to match the latest V8 implementation.
Node 12 added some limited support for async stack traces. I'm impressed that this package supports them, but it removes a useful annotation from them:
Given this file:
The stack traces without registering
source-map-support
is:With
source-map-support
registered is:I think the
async
annotation there is useful, as this stack trace is not the actual one as seen by v8, but an augmented one. This augmentation doesn't always work, and it would be surprising to the user if they look like normal stack traces.The text was updated successfully, but these errors were encountered: