From 4aa6a8665386a7ec5f4aff811b64f9f3aa862f0c Mon Sep 17 00:00:00 2001 From: Steven Berlanga Date: Wed, 29 Jul 2015 14:59:54 -0400 Subject: [PATCH 1/3] removing 'v' flag from verbose as codegansta/cli reserves that for version --- exercism/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercism/main.go b/exercism/main.go index 0d0432cf4..3b0cba2c1 100644 --- a/exercism/main.go +++ b/exercism/main.go @@ -50,7 +50,7 @@ func main() { EnvVar: "XDG_CONFIG_HOME,EXERCISM_CONFIG_FILE", }, cli.BoolFlag{ - Name: "verbose, v", + Name: "verbose", Usage: "turn on verbose logging", }, cli.BoolFlag{ From cd16e295f1def9d07039908f7add464164e59db6 Mon Sep 17 00:00:00 2001 From: Steven Berlanga Date: Wed, 29 Jul 2015 15:00:43 -0400 Subject: [PATCH 2/3] using 'verbose' flag instead of 'debug' --- CHANGELOG.md | 1 + cmd/submit.go | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index eb80fc478..120d45a6a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ The exercism CLI follows [semantic versioning](http://semver.org/). * [#200](https://github.com/exercism/cli/pull/200): Add guard to unsubmit command - [@kytrinyx](https://github.com/kytrinyx) * [#204](https://github.com/exercism/cli/pull/204): Improve upgrade failure messages and increase timeout - [@Tonkpils](https://github.com/Tonkpils) +* [#206](https://github.com/exercism/cli/pull/207): Fix verbose flag - [@zabawaba99](https://github.com/zabawaba99) * **Your contribution here** ## v2.2.0 (2015-06-27) diff --git a/cmd/submit.go b/cmd/submit.go index 097605438..7e9f83985 100644 --- a/cmd/submit.go +++ b/cmd/submit.go @@ -22,7 +22,7 @@ func Submit(ctx *cli.Context) { log.Fatal(err) } - if ctx.GlobalBool("debug") { + if ctx.GlobalBool("verbose") { log.Printf("Exercises dir: %s", c.Dir) dir, err := os.Getwd() if err != nil { @@ -41,13 +41,13 @@ func Submit(ctx *cli.Context) { log.Fatal(err) } - if ctx.GlobalBool("debug") { + if ctx.GlobalBool("verbose") { log.Printf("eval symlinks (dir): %s", dir) } files := []string{} for _, filename := range ctx.Args() { - if ctx.GlobalBool("debug") { + if ctx.GlobalBool("verbose") { log.Printf("file name: %s", filename) } @@ -61,7 +61,7 @@ func Submit(ctx *cli.Context) { log.Fatal(err) } - if ctx.GlobalBool("debug") { + if ctx.GlobalBool("verbose") { log.Printf("absolute path: %s", file) } @@ -70,7 +70,7 @@ func Submit(ctx *cli.Context) { log.Fatal(err) } - if ctx.GlobalBool("debug") { + if ctx.GlobalBool("verbose") { log.Printf("eval symlinks (file): %s", file) } From 5c0c1457fb82714cc97f1de1f1330b166d740e2e Mon Sep 17 00:00:00 2001 From: Steven Berlanga Date: Wed, 29 Jul 2015 15:28:01 -0400 Subject: [PATCH 3/3] update CHANGELOG --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 120d45a6a..d6edd8709 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,7 @@ The exercism CLI follows [semantic versioning](http://semver.org/). * [#200](https://github.com/exercism/cli/pull/200): Add guard to unsubmit command - [@kytrinyx](https://github.com/kytrinyx) * [#204](https://github.com/exercism/cli/pull/204): Improve upgrade failure messages and increase timeout - [@Tonkpils](https://github.com/Tonkpils) -* [#206](https://github.com/exercism/cli/pull/207): Fix verbose flag - [@zabawaba99](https://github.com/zabawaba99) +* [#206](https://github.com/exercism/cli/pull/207): Fix verbose flag and removed short `-v` - [@zabawaba99](https://github.com/zabawaba99) * **Your contribution here** ## v2.2.0 (2015-06-27)