Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tag commit #103

Closed
2 tasks done
extrawurst opened this issue Jun 1, 2020 · 7 comments · Fixed by #187
Closed
2 tasks done

tag commit #103

extrawurst opened this issue Jun 1, 2020 · 7 comments · Fixed by #187
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.9

Comments

@extrawurst
Copy link
Owner

extrawurst commented Jun 1, 2020 •
edited
Loading

In the commit log, I want to be able to tag the selected commit.

  • new command
  • text input popup
@extrawurst extrawurst added the enhancement New feature or request label Jun 1, 2020
@extrawurst extrawurst added the good first issue Good for newcomers label Jun 18, 2020
@cruessler
Copy link
Contributor

@extrawurst It looks like this issue is not taken yet. If that’s the case, I’d like to give it a try!

@extrawurst
Copy link
Owner Author

@cruessler absolutely! Looking forward. If u wanna chat about it or have any questions, feel free to join our discord too👍

@cruessler
Copy link
Contributor

Cool, thanks for the hint!

@cruessler
Copy link
Contributor

“In the commit log”, is that when you press 2 and then Enter on a commit?

@extrawurst
Copy link
Owner Author

no that's when you have the right-side commit-details open, right? I would expect this to be available even when being in plain reblog-view (only pressing [2])

@cruessler cruessler mentioned this issue Jul 8, 2020
Merged
2 tasks
@extrawurst extrawurst added this to the v0.9 milestone Jul 9, 2020
@extrawurst
Copy link
Owner Author

@cruessler looks great!
tagging

@cruessler
Copy link
Contributor

@extrawurst Thanks for the feedback! Looking forward to my next contribution! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.9
Development

Successfully merging a pull request may close this issue.

Add command for tagging commit cruessler/gitui
2 participants
@extrawurst @cruessler