Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: disable pull cmd on local-only branches #1047

Closed
extrawurst opened this issue Dec 15, 2021 · 5 comments · Fixed by #1051 or #1067
Closed

status: disable pull cmd on local-only branches #1047

extrawurst opened this issue Dec 15, 2021 · 5 comments · Fixed by #1051 or #1067
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@extrawurst
Copy link
Owner

based on conversations in #1045

@extrawurst extrawurst added the enhancement New feature or request label Dec 15, 2021
@extrawurst extrawurst added this to the v0.20 milestone Dec 15, 2021
@extrawurst extrawurst added the good first issue Good for newcomers label Dec 15, 2021
@mhmood-sf
Copy link

Somewhat related to this: disable all push/pull commands for repositories with no remotes? I tried [p] on a repository with no remotes and it exited gitui, with my terminal showing the output Error: git: inconclusive remotes. Here's the bugreport:

Software version

gitui 0.19.0 (cd639b2-modified)

Operating system

Linux 5.4.72-microsoft-standard-WSL2

Compile time information

  • Profile: release
  • Target triple: x86_64-unknown-linux-musl
  • Family: unix
  • OS: linux
  • Architecture: x86_64
  • Pointer width: 64
  • Endian: little
  • CPU features: fxsr,sse,sse2
  • Host: x86_64-unknown-linux-gnu

Environment variables

SHELL=/bin/bash
EDITOR=<not set>
GIT_EDITOR=<not set>
VISUAL=<not set>

Command-line

gitui --bugreport

@barkanido
Copy link

barkanido commented Dec 21, 2021

hey, @extrawurst I would like to try and tackle this. still a rust newbie. I am a loyal user of gitui :) WDYT?

@extrawurst
Copy link
Owner Author

I think if you look up there is already a PR for it - feel free to check it out locally and review it - I did not have time to do so yet.

@extrawurst
Copy link
Owner Author

extrawurst commented Dec 25, 2021

#1051 only handles the case where no remote is defined at all. we still need to fix the issue when a branch is not upstream but we have a remote defined. a local-only branch.

@barkanido please feel free to take a go at it

@extrawurst
Copy link
Owner Author

@barkanido ping. feel also free to join our discord to further discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants