Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove shift tab windows workaround #112

Closed
extrawurst opened this issue Jun 4, 2020 · 4 comments · Fixed by #425
Closed

remove shift tab windows workaround #112

extrawurst opened this issue Jun 4, 2020 · 4 comments · Fixed by #425
Labels
enhancement New feature or request good first issue Good for newcomers windows

Comments

@extrawurst
Copy link
Owner

extrawurst commented Jun 4, 2020 •
edited
Loading

fix the shift+tab modifier inconsistency in crossterm for windows upstream like we did with #26 and revert 38ee8c9 #111 afterwards
@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Jun 4, 2020
@extrawurst
Copy link
Owner Author

see crossterm-rs/crossterm#421

@extrawurst extrawurst mentioned this issue Jun 4, 2020
Merged
@extrawurst
Copy link
Owner Author

extrawurst commented Jun 28, 2020 •
edited
Loading

depends on crossterm-rs/crossterm#442

@stale
Copy link

stale bot commented Oct 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 5, 2020
@extrawurst
Copy link
Owner Author

crossterm-rs/crossterm#442 has actually been fixed, we just need to upgrade, remove the work around and test it

@stale stale bot removed the wontfix This will not be worked on label Oct 5, 2020
@nils-a nils-a mentioned this issue Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed tab_toggle_reverse_windows nils-a/gitui
1 participant
@extrawurst