Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch command in status tab for just the current branches remote #1471

Closed
alensiljak opened this issue Dec 12, 2022 · 8 comments · Fixed by #1483
Closed

Fetch command in status tab for just the current branches remote #1471

alensiljak opened this issue Dec 12, 2022 · 8 comments · Fixed by #1483
Labels
Milestone

Comments

@alensiljak
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I am looking for a quick and convenient way to see the incoming / outgoing commits in a repo. Related to #1413. Since F is mapped to Pull, I am wondering if there is a Fetch command. Perhaps it would be quicker to fetch changes and avoid potential merge issues.

Describe the solution you'd like
A fetch command in addition to pull.

Describe alternatives you've considered
Hm?

@alensiljak
Copy link
Contributor Author

One of the reasons I missed this functionality is that the Branches don't work on the phone and Fetch seems to be available in the Branches pop-up. Looking forward to that fix!

@extrawurst
Copy link
Owner

just to clarify: you would want the same fetch that currently is available in the branches window?

@alensiljak
Copy link
Contributor Author

alensiljak commented Dec 20, 2022

just to clarify: you would want the same fetch that currently is available in the branches window?

At the moment I can't answer that completely as I did not previously (due to the Branches bug on the phone) realize that functionality was there. I just had a brief look on desktop and the fetch of a branch seems to show the incoming commits on remote.

My general idea is to be able to manually refresh the changes count (up/down) from the Status page. Preferably this would be automatic but an explicit manual trigger (i.e. via F key) would also be fine.

I often get conflicts or unnecessary merges in my notes repository and seeing incoming commits would help. Thanks!

Edit: Not 100% sure about fetching all branches/remotes as I normally have 1 of each in the problematic repos. In other cases, I'd normally like to control which remote and/or branch I want to fetch.

@extrawurst
Copy link
Owner

extrawurst commented Dec 20, 2022

(due to the Branches bug on the phone)

that was #1470 ? feel free to test with a build from master

@alensiljak
Copy link
Contributor Author

(due to the Branches bug on the phone)

that was #1470 ? feel free to test with a build from master

Correct. Alright, let me try cargo install directly from the repo...

@alensiljak
Copy link
Contributor Author

Unfortunately, I don't know how to overcome the last hurdle. Linking with cc fails on the last package (gitui) due to an undefined symbol __aarch64_ldadd4_acq_rel. I'll try some more but might ultimately need to wait for the binary release for aarch64-linux-android (or a Termux package).

I'm a bit confused about how the current fetch works. I don't see an indication of the number of changes in the branches window but only when back to the Status screen. Which is kinda ok, I guess.

To add to my previous comment, I think that fetching the currently linked remote branch would be ok if done directly from the Status screen.

@alensiljak
Copy link
Contributor Author

Just tried on desktop - the workflow seems to be:

  • open Branches pop-up
  • switch to remote tab
  • fetch changes
  • close the pop-up
  • observe the number of changes

The pop-up covers the change indicator below and needs to be closed in order to see the result of the fetch operation.
image

Also, it is not clear what the fetch will do - does it fetch all branches or just the current one.

Therefore, I would suggest that there is a fetch operation added to the Status (main) window, which fetches the currently-linked branch, if available. I think all the logic is already in place so it is a matter of adding the command to the UI.

@extrawurst
Copy link
Owner

fetch in the branch popup fetches everything. a dedicated fetch in the status view to just fetch the current remote branch makes sense 👍

@extrawurst extrawurst changed the title Fetch command Fetch command in status tab for just the current branches remote Dec 21, 2022
@extrawurst extrawurst added this to the v0.23 milestone Dec 21, 2022
@extrawurst extrawurst added the good first issue Good for newcomers label Dec 21, 2022
@alensiljak alensiljak mentioned this issue Dec 21, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants