Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support prepare-commit-msg hook #1873

Closed
extrawurst opened this issue Sep 4, 2023 · 5 comments · Fixed by #1978
Closed

support prepare-commit-msg hook #1873

extrawurst opened this issue Sep 4, 2023 · 5 comments · Fixed by #1978
Milestone

Comments

@extrawurst
Copy link
Owner

spun off of #1711.

@pm100 are you still going to provide a PR on this?

@pm100
Copy link
Contributor

pm100 commented Sep 4, 2023

I have working code but I am blocked trying to work out what to do with the hook sequencing (as raised in #1711). I cant say I like what you propose for that (there would be no way to prevent the pre-commit running for example) I see you said that its a low priority for you, but it would be nice to have hook parity with git cli

@extrawurst
Copy link
Owner Author

I have working code but I am blocked trying to work out what to do with the hook sequencing

don't see why the order matters for prepare-commit-msg - it operates on the commit message (default). It simply runs when the commit popup opens.

lets discuss your concerns in #1711

@extrawurst
Copy link
Owner Author

@pm100
Copy link
Contributor

pm100 commented Dec 15, 2023

I have code pretty much working but disappeared down the textinput rabbit hole for months. Spent a long long time getting features added to it so that it works nicely in gitui. I also worked out how to make it work by only changing one file in gitui. There are also real nice features that I got in coming in their next version , including full kb driven text select / copy / paste to and from the text area. Fixes your unicode bug(s) too. The only thing blocking it is the whole cargo update versioning thing: my PR ends up having bitflags 2 pulled in, plus a different version of syn.

@extrawurst
Copy link
Owner Author

no worries. the comment was only a reminder for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants