Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support wayland copy to clipboard #397

Closed
extrawurst opened this issue Nov 1, 2020 · 6 comments · Fixed by #1233
Closed

support wayland copy to clipboard #397

extrawurst opened this issue Nov 1, 2020 · 6 comments · Fixed by #1233
Labels
enhancement New feature or request good first issue Good for newcomers wontfix This will not be worked on

Comments

@extrawurst
Copy link
Owner

according to @1wilkens in #390 our current copy to clipboard binaries may not cover wayland (correct me if I am wrong).

maybe we can use this opportunity to cleanup the support for multiple fallback programs for running copy to clipboard:

  • use which on all platforms
  • have a list of platforms specific programs
  • try them all before erroring out
@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Nov 1, 2020
@extrawurst extrawurst added this to the v0.11 milestone Nov 1, 2020
@1wilkens
Copy link
Contributor

1wilkens commented Nov 1, 2020

While we can certainly do that, we could also use a rust library to handle the clipboard. There are several choices, but copypasta seems to be the most up-to-date one. I can understand if you don't want to add a (potentially) heavy dependency, however we already included which just for clipboard support, so I would actually use the abstraction from a proper clipboard library.

@extrawurst
Copy link
Owner Author

@1wilkens good thinking, but we have been there and tried that and reverted it because of dynamic dependencies that these libraries introduce: #261

which only needs libc and can still compile to a static binary

@1wilkens
Copy link
Contributor

1wilkens commented Nov 1, 2020

My bad, I should have looked maybe ;) In this case, the proposed solution seems good. I'll try to address the wayland part in a PR soon :)

@extrawurst extrawurst removed this from the v0.11 milestone Nov 12, 2020
@stale
Copy link

stale bot commented Feb 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 10, 2021
@stale stale bot closed this as completed Feb 17, 2021
@cas7breeder
Copy link

cas7breeder commented Mar 21, 2021

Can this be reopened? Using wl-copy on Wayland here. Great tool gitui!

@extrawurst
Copy link
Owner Author

@cas7breeder feel free to reopen it if you are about to submit a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants