Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search commits for message or author #429

Closed
WizardOhio24 opened this issue Nov 17, 2020 · 7 comments
Closed

Search commits for message or author #429

WizardOhio24 opened this issue Nov 17, 2020 · 7 comments
Labels
dormant Marked by stale bot on close enhancement New feature or request

Comments

@WizardOhio24
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It would be good to be able to search the commit list for words in the commit message, or in the author name(i.e filter by author). For example, if you wanted to go back several hundred commits to find what a commit did, or a previous implementation, and you knew what the commit message contains, it would be good to just search for it, rather than scrolling through hundreds of commit messages to find that one commit.

Describe the solution you'd like
Press a button, perhaps f or s, and be able to search the commit list for words. This should search both author and commit message.

Describe alternatives you've considered
Scrolling through hundreds of commits

@extrawurst extrawurst added the enhancement New feature or request label Jan 11, 2021
@stale
Copy link

stale bot commented Apr 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 11, 2021
@willir
Copy link

willir commented Apr 16, 2021

This feature is actually pretty important to me. And as far as I can tell the pull request is in progress, so just posting to keep the issue open.

@stale stale bot removed the wontfix This will not be worked on label Apr 16, 2021
@extrawurst
Copy link
Owner

@willir thanks for your interest, unfortunately the PR seems abandoned. feel free to pick it up :)

@willir
Copy link

willir commented Apr 16, 2021

@extrawurst, Oh, I see. Thanks for the quick response! I'll try to find time to finish that PR.

@WizardOhio24
Copy link
Contributor Author

WizardOhio24 commented Apr 16, 2021

Yeah, author of the PR here, I haven't found the time to finish it (not abandoned, but halted), currently the feature is implemented, it works (instructions are in the PR(#506)) but the code needs refined, some of the functions are quite big. I'm going to be pretty busy for the next month but after that I would be able to finish it. But feel free to take it on, the code just needs to be made better (some doc and tests added), and feel free to ask any questions about it.

@willir
Copy link

willir commented Apr 25, 2021

Hi @WizardOhio24 @extrawurst, I've created a new pull requests #672 with some comments fixed. I'll try to find time to fix other comments a bit later.

@stale
Copy link

stale bot commented Jul 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dormant Marked by stale bot on close enhancement New feature or request
Projects
None yet
3 participants