Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Markdown emoji #768

Closed
Sebclem opened this issue Jun 4, 2021 · 2 comments · Fixed by #866
Closed

Support Markdown emoji #768

Sebclem opened this issue Jun 4, 2021 · 2 comments · Fixed by #866
Labels
Milestone

Comments

@Sebclem
Copy link

Sebclem commented Jun 4, 2021

Is your feature request related to a problem? Please describe.
I'm using a lot of markdown emoji in my commits message, but in gitui, the emoji are not parsed.

Describe the solution you'd like
Replace all markdown emoji by it's Unicode equivalent.

I have found this lib that can help: https://lib.rs/crates/gh-emoji

Describe alternatives you've considered

Additional context
image

This should look like this:
image

@extrawurst
Copy link
Owner

extrawurst commented Jun 5, 2021

Hi @Sebclem I dont find that feature particularly important but I wouldn't mind it if anyone wants to pick it up👍

Note: In case anyone wants to tackle this - make sure to not run the parser on every draw but just on the cache of commits we keep in memory

@extrawurst extrawurst added the good first issue Good for newcomers label Jun 5, 2021
@andrewpollack
Copy link
Contributor

This looks like a fun issue 😄 mind if I give this a go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants