Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker.push should not push the tags when the docker.skip.tag is presented #869

Open
meggarr opened this issue Sep 26, 2017 · 2 comments
Open

Comments

@meggarr
Copy link

meggarr commented Sep 26, 2017

Description

When I have my pom.xml define the tags in both <name> and <tags>, e.g.

<name>myimage:${project.version}.${build.number}</name>
<build>
  <tags>
    <tag>latest</tag>
  </tags>
</build>

I want to build the image for default tag only and push the image to remote, via

mvn clean package docker:build docker:push \
        -Ddocker.push.registry=<my-registry> \
        -Ddocker.skip.tag=true

The it still tries to push the image with tag latest while it's skipped in build.

Info

The docker.push should not push the tags when the docker.skip.tag is presented.

  • d-m-p version : 0.20.2
  • Maven version (mvn -v) : 3.0.5
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 21:51:28+0800)
Maven home: /works/apps/apache-maven-3.0.5
Java version: 1.8.0_111, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-79-generic", arch: "amd64", family: "unix"
  • Docker version : 1.12.6
@MrMarkW
Copy link

MrMarkW commented Feb 15, 2018

@rhuss - Have you guys looked at this one?

I'm having this same issue. In our "snapshot" builds, we create the image and tag, then on releases, we only create the image, but it still tries to push the tag that wasn't created.

@rhuss
Copy link
Collaborator

rhuss commented Feb 20, 2018

Sorry, haven't looked at it yet. I'm currently on the road and quite busy these days, but I will have a look when I'm back.

If you feel fancy (and want accelerate things), I'm happily integrating pull requests, too ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants