Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: There is a significant difference in filter performance between Fabric.js version 6 and version 5. #10099

Open
7 tasks done
luo-sb opened this issue Aug 28, 2024 · 1 comment
Assignees

Comments

@luo-sb
Copy link

luo-sb commented Aug 28, 2024

CheckList

  • I agree to follow this project's Code of Conduct
  • I have read and followed the Contributing Guide
  • I have read and followed the Issue Tracker Guide
  • I have searched and referenced existing issues and discussions
  • I am filing a BUG report.
  • I have managed to reproduce the bug after upgrading to the latest version
  • I have created an accurate and minimal reproduction

Version

6.0.2

In What environments are you experiencing the problem?

Chrome

Node Version (if applicable)

None

Link To Reproduction

None

Steps To Reproduce

I tried to use fabric.filters.RemoveColor in Fabric.js to remove the green screen from a video and then play it on the canvas. In version 5, the performance was as expected, and the playback was smooth. However, in version 6, it became very laggy. I discovered that the fabric.Image.applyFilters() method takes only 10ms to execute in version 5, but it takes 350ms-450ms in version 6.

Is this a bug, or is there something wrong with my code?

"This zip file contains the two versions of test demos that I wrote."
fabricjs-demo.zip

Expected Behavior

It becomes as smooth as it was in version 5.

Actual Behavior

.

Error Message & Stack Trace

No response

@asturur
Copy link
Member

asturur commented Aug 28, 2024

Hopefully is a bug we can fix.
Is the difference visible in a single frame? or just on continued use? do you have any idea?

@asturur asturur self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants