Amazing job!

[bobbysebolao]

Hi all, hope you had a great time fighting food wastage this week. Well done on a great project!

I've added my thoughts on a few things below. I struggled to find much to critique in a lot of ways - you've succeeded with many things that I think got the better of me at this point in the course. Hope these few suggestions are useful (either now or in your next project).

UI ✨

• I like the slanted angle on the shopping list on the 'Select your items' page, is a nice touch 🔆
• It’s so so good that you’ve found time to carry out thorough accessibility checks 🥇
• Everything looks 👌 on 📱 😎

One tiny thing I noticed is that the cursor style on the 'Select your items' page doesn't change to the cursor: pointer when you hover over the grocery items, or the submit button. You can change that to show desktop users that it's clickable.

Image optimisation 🖼

Some of the images in your assets folder could be compressed for faster loading. It might not be noticeable on the lightning fast WiFi speeds we're all used to, but when you throttle your connection speed in the Chrome dev tools, websites with lots of images can be slow to load. You can use a website like tinypng.com to compress them before you add them to your project:

Another good move would be to use the compression express module (I believe you can install it from npm) to compress HTTP responses from your server. You should be able to slot it into your express server just like the other middleware that you're already using.

Testing 💯

You've got really thorough suite of tests in place, and I would imagine your test coverage is high. If you want you can show this off, you can, by adding a code coverage badge to your readme. To do this you can use codecov.io, it's a service that watches your passing Travis CI builds and generates code coverage reports to show you how much of your code (and which parts) are covered by your tests. I remember it being reasonably straightforward to set up. And you get a lil badge for your readme.

(you can also get a different badge from Travis to show that your build is passing)

I like your approach to writing tests for the DOM (by searching for the HTML DOCTYPE), it's clever! You'll be doing a lot more DOM testing when you start using React (and, thankfully, there's a testing library with built in methods for selecting DOM elements) so it's awesome that you're already thinking about this.

Modular code 👨‍💻 👩‍💻

I think you've done a nice job of writing modular code and splitting functions into separate files where that makes sense. I bet this has minimised situations where more than one person was working on the same file - looking at your network graph I can see you haven't had too many merge conflicts.

Plus, your code is clean and easy to read thanks to all the comments you've written for each other. I'm sure your future selves will thank your present selves for taking the time to write these messages.

WELL DONE AGAIN!

[jackbridger]

Thanks Bobby this is really helpful!

[gminova]

Awww Bobby, thank you!! ❤️ @bobbysebolao

[andy-mc-donald]

Thanks Bobby!