Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Workbox to 4.1.0 #6659

Closed
jadbox opened this issue Mar 15, 2019 · 5 comments · Fixed by #6725
Closed

Update Workbox to 4.1.0 #6659

jadbox opened this issue Mar 15, 2019 · 5 comments · Fixed by #6725

Comments

@jadbox
Copy link

jadbox commented Mar 15, 2019

Currently the generated service worker workbox version is:
importScripts("https://storage.googleapis.com/workbox-cdn/releases/3.6.3/workbox-sw.js")

The latest is 4.1: see https://github.com/GoogleChrome/workbox/releases
The import can now read as:
importScripts("https://storage.googleapis.com/workbox-cdn/releases/4.1.0/workbox-sw.js")

This update improves a number of things, including adding the much needed skipWaiting() message handler:
GoogleChrome/workbox#1929

@r0ughnex
Copy link
Contributor

r0ughnex commented Mar 23, 2019

There are a number of issues with the service worker from the older version of the plugin. I ejected create-react-app and updated the version number in the package.json to 4.1.1 (latest version of workbox-webpack-plugin).

Most of these issues have now been resolved in the new version, and nothing else is required apart from updating the version number of the npm module. This should be a relatively simple update.

@iansu
Copy link
Contributor

iansu commented Mar 24, 2019

@r0ughnex would you like to submit a PR?

@iansu iansu self-assigned this Mar 24, 2019
@r0ughnex
Copy link
Contributor

r0ughnex commented Mar 24, 2019

@iansu: Sure, I'll take this one up.

@r0ughnex
Copy link
Contributor

@iansu: One more thing, I was having this issue on Chrome (on Windows 10) with version 3.6.3, but updating it to 4.1.1 resolved it. I can't reference the issue. It was auto-lock closed because it went stale.

@r0ughnex
Copy link
Contributor

@jadbox, @iansu: PR submitted for this issue.

@lock lock bot locked and limited conversation to collaborators Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants