Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRA@3: Eject warning message references CRA2 #6838

Closed
petetnt opened this issue Apr 17, 2019 · 0 comments · Fixed by #6845
Closed

CRA@3: Eject warning message references CRA2 #6838

petetnt opened this issue Apr 17, 2019 · 0 comments · Fixed by #6845
Milestone

Comments

@petetnt
Copy link
Contributor

petetnt commented Apr 17, 2019

The warning message links to the CRA2 release blog post, but we probably want to link some page in the docs (eg. extended https://facebook.github.io/create-react-app/docs/alternatives-to-ejecting) where these things are explained briefly.

console.log(
chalk.cyan.bold(
'NOTE: Create React App 2 supports TypeScript, Sass, CSS Modules and more without ejecting: ' +
'https://reactjs.org/blog/2018/10/01/create-react-app-v2.html'
)
);
console.log();

Steps to Reproduce

1.Create a new CRA3 app with npx create-react-app@3.0.0-next.68 foobar
2. cd foobar
3. yarn eject

Expected Behavior

Eject message references to CRA3

Actual Behavior

We see the following warning:

NOTE: Create React App 2 supports TypeScript, Sass, CSS Modules and more without ejecting: https://reactjs.org/blog/2018/10/01/create-react-app-v2.html

Reproducible Demo

image

@petetnt petetnt changed the title Eject warning message references CRA2 CRA@3: Eject warning message references CRA2 Apr 17, 2019
@iansu iansu added this to the 3.0 milestone Apr 18, 2019
@lock lock bot locked and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants