Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint v6 was released. #7268

Closed
ndrsllwngr opened this issue Jun 23, 2019 · 15 comments · Fixed by #7415
Closed

ESLint v6 was released. #7268

ndrsllwngr opened this issue Jun 23, 2019 · 15 comments · Fixed by #7415

Comments

@ndrsllwngr
Copy link

ndrsllwngr commented Jun 23, 2019

ESLint v6 was released yesterday. https://github.com/eslint/eslint/releases/tag/v6.0.0
Yet create-react-app has yet not released a new version, which includes the #7219 PR which fixes the #7218 issue.

Just wanted to let you know, that this fix should be released asap. As ESLint v6 is now the latest version on https://www.npmjs.com/package/eslint and a lot of people are going to experience this #7218 issue pretty soon.

@ianschmitz
Copy link
Contributor

Our users will still be using ESLint 5 until we bump the version, so #7218 shouldn't be an issue. Thanks for the heads up though!

@mrmckeb we may want to test v6 with your ESLint PR?

@ndrsllwngr
Copy link
Author

Our users will still be using ESLint 5 until we bump the version, so #7218 shouldn't be an issue. Thanks for the heads up though!

I may quote @ivan-aksamentov at this point:

Please note that this issue affects users beyond create-react-app, because many projects use eslint-config-react-app as a starting points for their eslint configurations. These users are unable to try Eslint 6 until this is sorted out.

A lot of projects make use of the npmjs.com/package/eslint-config-react-app eslint conf, as well does our project; therefore, the fix to be able to upgrade to ESLint v6 would be much appreciated.

@bugzpodder
Copy link

@ndrsllwngr this is on our radar. Once we do appropriate tests have been done we'll do the upgrade. The expectation that we upgrade within 24 hours is not reasonable.

@mrmckeb mrmckeb self-assigned this Jun 24, 2019
@mrmckeb
Copy link
Contributor

mrmckeb commented Jun 24, 2019

@ndrsllwngr as @bugzpodder said, we're working on this.

With all dependencies, we need to consider breaking changes. In this case, we're worried about a change to one specific rule and are currently discussing that.

Hopefully we can get this in with #7036 - as I want to merge that PR in the next few days.

@Primajin
Copy link
Contributor

Primajin commented Jun 25, 2019

Also overrides in the config / eslintrc should be wrapped in an array.

Error: ESLint configuration in .eslintrc.js » eslint-config-react-app is invalid:
	- Property "overrides" is the wrong type (expected array but got `{"files….

I’m happy to send a PR but couldn’t find my way to the file I’d need to change…

EDIT: Fixed in #7219 - ignore this comment 🤦‍♂

@mrmckeb
Copy link
Contributor

mrmckeb commented Jun 25, 2019

Yes, this was fixed @Primajin - don't worry, I also spotted it yesterday and also went "Oh, already fixed!".

@vadimka123
Copy link

Date of release fix ?

@lonewarrior556
Copy link

lonewarrior556 commented Jul 8, 2019

@bugzpodder "The expectation that we upgrade within 24 hours is not reasonable." commented 15 days ago

Any update?

@bugzpodder
Copy link

@lonewarrior556 not yet. 3.0.2 should be released soon but no firm date yet.

@lonewarrior556
Copy link

lonewarrior556 commented Jul 9, 2019

@mrmckeb Is it possible to just minor bump https://www.npmjs.com/package/eslint-config-react-app with the fix? And not wait on 3.0.2 of https://www.npmjs.com/package/create-react-app?

It's a minor change that fixes a bug, It should be enough to unblock anyone trying to use eslint 6.0

@mrmckeb
Copy link
Contributor

mrmckeb commented Jul 15, 2019

Hi @lonewarrior556, we're waiting for this to be resolved... typescript-eslint/typescript-eslint#644

It's still listing v5 a the dependency. Please feel free to help push that through.

@Primajin
Copy link
Contributor

Primajin commented Jul 15, 2019

But couldn't we just push out the change from #7219 which should be backwards compatible so both v5 and v6 users could use it? And then do everything else later in a higher version bump?

@frontendphil
Copy link

It seems like every issue that was mentioned in here as a dependency/blocker has been resolved. Any update on the matter?

@baitun
Copy link

baitun commented Jul 22, 2019

It seems like every issue that was mentioned in here as a dependency/blocker has been resolved. Any update on the matter?

Yes, it's resolved, but new version is not released yet, so we all are waiting for release 3.1.

@mrmckeb
Copy link
Contributor

mrmckeb commented Jul 25, 2019

Correct, I hope this will be out in the next week :)

@bugzpodder bugzpodder changed the title ESLint v6 was released yesterday. ESLint v6 was released. Jul 25, 2019
@lock lock bot locked and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants