Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in eslint-import-order 2.20.1 #8883

Closed
macropp opened this issue Apr 23, 2020 · 6 comments
Closed

Bug in eslint-import-order 2.20.1 #8883

macropp opened this issue Apr 23, 2020 · 6 comments

Comments

@macropp
Copy link

macropp commented Apr 23, 2020

Describe the bug

react-scripts package uses older version of eslint-import-order package, which doesn't work for Windows because of a bug (import-js/eslint-plugin-import#1643). The bug is fixed in v2.20.2.

Did you try recovering your dependencies?

Yes.

Which terms did you search for in User Guide?

I don't think it has to do anything with user guide.

Environment

`Environment Info:

current version of create-react-app: 3.4.1
running from C:\Users\Gio\AppData\Roaming\npm-cache_npx\14328\node_modules\create-react-app

System:
OS: Windows 10 10.0.18363
CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Binaries:
Node: 12.16.2 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.14.4 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: 44.18362.449.0
Internet Explorer: 11.0.18362.1
npmPackages:
react: ^16.13.1 => 16.13.1
react-dom: ^16.13.1 => 16.13.1
react-scripts: ^3.4.1 => 3.4.1
npmGlobalPackages:
create-react-app: Not Found
`

Steps to reproduce

  1. Create new app using Typescript template
  2. Import react, as well as local files
  3. Observe inconsistent behaviour between MacOS and Windows, making it impossible to use same codebase on both platforms without disabling the rule.

Expected behavior

Eslint shouldn't complain on imports between OS-s.

Actual behavior

Eslint shows import order errors on Windows, but works fine on MacOS.
image

Reproducible demo

I think this is just wasted time, since the bug is not in the repo itself but in one of its dependencies. Please just update the offending dependency and give us a new release 🙏

@waterfoul
Copy link

This is a blocker for us, please update since this is fixed in a point release of the offending package

@copiali
Copy link

copiali commented May 11, 2020

Have same issue....I downgrade CRA to 3.4.0 for now.

@stale
Copy link

stale bot commented Jun 10, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jun 10, 2020
@macropp
Copy link
Author

macropp commented Jun 11, 2020

This issue is still active and forces us to use an older version of CRA or disable the rule. Just commenting here so that the bot doesn't close it.

@stale stale bot removed the stale label Jun 11, 2020
@stale
Copy link

stale bot commented Jul 11, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jul 11, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.

@stale stale bot closed this as completed Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants