From 668efcca57822436fb7d0dd7e879dd46c330fe7b Mon Sep 17 00:00:00 2001 From: Daniel Famakin Date: Fri, 16 Aug 2024 09:37:40 -0700 Subject: [PATCH] RU needsUpdate -> shouldUpdate Summary: per comments on D61265667 Differential Revision: D61383856 fbshipit-source-id: 78c10c601f06973b21992b801bfd54698d7086d7 --- .../src/main/java/com/facebook/rendercore/MountState.kt | 2 +- .../src/main/java/com/facebook/rendercore/RenderUnit.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/litho-rendercore/src/main/java/com/facebook/rendercore/MountState.kt b/litho-rendercore/src/main/java/com/facebook/rendercore/MountState.kt index e424280691..3669654d4f 100644 --- a/litho-rendercore/src/main/java/com/facebook/rendercore/MountState.kt +++ b/litho-rendercore/src/main/java/com/facebook/rendercore/MountState.kt @@ -845,7 +845,7 @@ constructor( currentMountItem.update(renderTreeNode) currentRenderUnit.onStartUpdateRenderUnit() mountDelegate?.startNotifyVisibleBoundsChangedSection() - if (currentRenderUnit.needsUpdate(renderUnit) || + if (currentRenderUnit.shouldUpdate(renderUnit) || !isEqualOrEquivalentTo(currentLayoutData, newLayoutData)) { val traceIdentifier = DebugEventDispatcher.generateTraceIdentifier(DebugEvent.RenderUnitUpdated) diff --git a/litho-rendercore/src/main/java/com/facebook/rendercore/RenderUnit.kt b/litho-rendercore/src/main/java/com/facebook/rendercore/RenderUnit.kt index a100315d23..01059f9467 100644 --- a/litho-rendercore/src/main/java/com/facebook/rendercore/RenderUnit.kt +++ b/litho-rendercore/src/main/java/com/facebook/rendercore/RenderUnit.kt @@ -653,7 +653,7 @@ constructor( } } - open fun needsUpdate(newRenderUnit: RenderUnit): Boolean = this !== newRenderUnit + open fun shouldUpdate(newRenderUnit: RenderUnit): Boolean = this !== newRenderUnit open fun ?> findAttachBinderByClass(klass: Class): T? { return attachBinderTypeToDelegateMap?.get(klass)?.binder as T?