From 2b932c3820cfabef1590f6fcf8b95f65d9c21eb8 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Mon, 15 May 2023 15:21:56 -0700 Subject: [PATCH] Change how we set cmake policy (#37349) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37349 X-link: https://github.com/facebook/yoga/pull/1288 Fixes https://github.com/facebook/yoga/issues/1283 New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`. Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions. Googling around, apparently the way I should be doing this is to specify `` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392 This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum. Reviewed By: cortinico Differential Revision: D45724864 fbshipit-source-id: 120cc2015a043605e7c07ef0459667643a4284b7 --- packages/react-native/ReactCommon/yoga/yoga/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/yoga/yoga/CMakeLists.txt b/packages/react-native/ReactCommon/yoga/yoga/CMakeLists.txt index e51f36795388b5..b6eca1ac7232de 100644 --- a/packages/react-native/ReactCommon/yoga/yoga/CMakeLists.txt +++ b/packages/react-native/ReactCommon/yoga/yoga/CMakeLists.txt @@ -4,7 +4,7 @@ # LICENSE file in the root directory of this source tree. -cmake_minimum_required(VERSION 3.13) +cmake_minimum_required(VERSION 3.13...3.26) project(yogacore) set(CMAKE_VERBOSE_MAKEFILE on)