From 475a15631056f03822352f798158aa956b782ddd Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Sun, 18 Feb 2024 11:23:47 -0800 Subject: [PATCH] Make React-jsiinspector depends on hermes-engine to fix Dynamic Frameworks (#43081) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43081 When Hermes i used, it is hermes that provides JSI to React Native and not React-jsi. This is required to fix the ODR violatons. Dynamic frameworks requires that all the dependencies are declared explicitly, and missing the `hermes-engine` dependency was breaking the dependency graph. ## Changelog [Internal] - Make JSIInspector depends o hermes-engine Reviewed By: motiz88 Differential Revision: D53901016 fbshipit-source-id: a511719647e6203d082696fd572593fd851a1dde --- .../ReactCommon/jsinspector-modern/React-jsinspector.podspec | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/React-jsinspector.podspec b/packages/react-native/ReactCommon/jsinspector-modern/React-jsinspector.podspec index aec8970f45bfb7..e338fcd843e9b9 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/React-jsinspector.podspec +++ b/packages/react-native/ReactCommon/jsinspector-modern/React-jsinspector.podspec @@ -53,4 +53,8 @@ Pod::Spec.new do |s| s.dependency "DoubleConversion" s.dependency "React-runtimeexecutor", version s.dependency "React-jsi" + if ENV["USE_HERMES"] == nil || ENV["USE_HERMES"] == "1" + s.dependency "hermes-engine" + end + end