From 68e55284c57d3549742458220e206916d5941b74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20Norte?= Date: Wed, 18 Sep 2024 10:09:11 -0700 Subject: [PATCH] Ship correct fix for state updates after smooth scroll animation (#46564) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46564 Changelog: [internal] I incorrectly set up an experiment to fix reported scroll position during smooth scroll animations on Android in D59233069. It was incorrect because I fixed the issue in "control", and I re-enabled the bug in "test". That means we actually shipped the fix the moment we set up the experiment. We can just apply the fix ungated. Reviewed By: Abbondanzo Differential Revision: D62965254 fbshipit-source-id: edf855619ff9ede6fd406f7f19b3c504ce89f1d6 --- .../com/facebook/react/views/scroll/ReactScrollViewHelper.kt | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.kt index e2c3922656da8a..5877312d0e39a8 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewHelper.kt @@ -246,8 +246,6 @@ public object ReactScrollViewHelper { if (scrollY != y) { scrollView.startFlingAnimator(scrollY, y) } - - updateFabricScrollState(scrollView, x, y) } /** Get current position or position after current animation finishes, if any. */