From 806a2b810319ec6fef63bc4b36f89d49baf3f7c2 Mon Sep 17 00:00:00 2001
From: Valentin Shergin <shergin@fb.com>
Date: Fri, 15 Nov 2019 21:47:51 -0800
Subject: [PATCH] Fabric: `ShadowTreeDelegate::shadowTreeDidCommit` was renamed
 to `shadowTreeDidFinishTransaction`

Summary:
Simple renaming. Now the name is aligned with `SchedulerDelegate::schedulerDidFinishTransaction` and actually expresses the idea that not only commit finished but also a transaction was prepared and layout events were sent.

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: mdvacca

Differential Revision: D18542503

fbshipit-source-id: 54d429ed139383621fe926fa48a4de062f724176
---
 ReactCommon/fabric/mounting/ShadowTree.cpp       | 2 +-
 ReactCommon/fabric/mounting/ShadowTreeDelegate.h | 2 +-
 ReactCommon/fabric/uimanager/UIManager.cpp       | 4 ++--
 ReactCommon/fabric/uimanager/UIManager.h         | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/ReactCommon/fabric/mounting/ShadowTree.cpp b/ReactCommon/fabric/mounting/ShadowTree.cpp
index f37b1b30316022..ce1689d7a87db8 100644
--- a/ReactCommon/fabric/mounting/ShadowTree.cpp
+++ b/ReactCommon/fabric/mounting/ShadowTree.cpp
@@ -198,7 +198,7 @@ bool ShadowTree::tryCommit(ShadowTreeCommitTransaction transaction) const {
       ShadowTreeRevision{newRootShadowNode, revisionNumber, telemetry});
 
   if (delegate_) {
-    delegate_->shadowTreeDidCommit(*this, mountingCoordinator_);
+    delegate_->shadowTreeDidFinishTransaction(*this, mountingCoordinator_);
   }
 
   return true;
diff --git a/ReactCommon/fabric/mounting/ShadowTreeDelegate.h b/ReactCommon/fabric/mounting/ShadowTreeDelegate.h
index 7d65e6b5e3dd86..c58170d1662125 100644
--- a/ReactCommon/fabric/mounting/ShadowTreeDelegate.h
+++ b/ReactCommon/fabric/mounting/ShadowTreeDelegate.h
@@ -22,7 +22,7 @@ class ShadowTreeDelegate {
   /*
    * Called right after Shadow Tree commit a new state of the the tree.
    */
-  virtual void shadowTreeDidCommit(
+  virtual void shadowTreeDidFinishTransaction(
       ShadowTree const &shadowTree,
       MountingCoordinator::Shared const &mountingCoordinator) const = 0;
 
diff --git a/ReactCommon/fabric/uimanager/UIManager.cpp b/ReactCommon/fabric/uimanager/UIManager.cpp
index 59572319f391aa..dbd03c72bad6c3 100644
--- a/ReactCommon/fabric/uimanager/UIManager.cpp
+++ b/ReactCommon/fabric/uimanager/UIManager.cpp
@@ -298,10 +298,10 @@ ShadowTreeRegistry const &UIManager::getShadowTreeRegistry() const {
 
 #pragma mark - ShadowTreeDelegate
 
-void UIManager::shadowTreeDidCommit(
+void UIManager::shadowTreeDidFinishTransaction(
     ShadowTree const &shadowTree,
     MountingCoordinator::Shared const &mountingCoordinator) const {
-  SystraceSection s("UIManager::shadowTreeDidCommit");
+  SystraceSection s("UIManager::shadowTreeDidFinishTransaction");
 
   if (delegate_) {
     delegate_->uiManagerDidFinishTransaction(mountingCoordinator);
diff --git a/ReactCommon/fabric/uimanager/UIManager.h b/ReactCommon/fabric/uimanager/UIManager.h
index e02fa2be507131..b0ed2e6339dc5b 100644
--- a/ReactCommon/fabric/uimanager/UIManager.h
+++ b/ReactCommon/fabric/uimanager/UIManager.h
@@ -50,7 +50,7 @@ class UIManager final : public ShadowTreeDelegate {
 
 #pragma mark - ShadowTreeDelegate
 
-  void shadowTreeDidCommit(
+  void shadowTreeDidFinishTransaction(
       ShadowTree const &shadowTree,
       MountingCoordinator::Shared const &mountingCoordinator) const override;