From 8a80d613f5a900de420c3d12cf5ffa475068f418 Mon Sep 17 00:00:00 2001 From: Peter Argany Date: Wed, 24 Jul 2019 10:45:22 -0700 Subject: [PATCH] Deprecate RCTImageLoader category of RCTBridge [2/N] Summary: We no longer want to access RCTImageLoader from the bridge. Reviewed By: shergin Differential Revision: D16389383 fbshipit-source-id: 8e006bf0e2e2651f3ac036c09e589213ac9d29f9 --- Libraries/Image/RCTImageLoader.h | 7 ++++--- Libraries/Image/RCTImageLoader.m | 6 ++++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/Libraries/Image/RCTImageLoader.h b/Libraries/Image/RCTImageLoader.h index 1c32eab93f8e1e..3e9d3e30f4cbaf 100644 --- a/Libraries/Image/RCTImageLoader.h +++ b/Libraries/Image/RCTImageLoader.h @@ -155,11 +155,12 @@ typedef dispatch_block_t RCTImageLoaderCancellationBlock; @end -@interface RCTBridge (RCTImageLoader) - /** - * The shared image loader instance + * DEPRECATED!! DO NOT USE + * Instead use `[_bridge moduleForClass:[RCTImageLoader class]]` */ +@interface RCTBridge (RCTImageLoader) + @property (nonatomic, readonly) RCTImageLoader *imageLoader; @end diff --git a/Libraries/Image/RCTImageLoader.m b/Libraries/Image/RCTImageLoader.m index 6b80d47f69a90e..3e50800f407e82 100644 --- a/Libraries/Image/RCTImageLoader.m +++ b/Libraries/Image/RCTImageLoader.m @@ -936,10 +936,16 @@ - (void)cancelRequest:(id)requestToken @end +/** + * DEPRECATED!! DO NOT USE + * Instead use `[_bridge moduleForClass:[RCTImageLoader class]]` + */ @implementation RCTBridge (RCTImageLoader) - (RCTImageLoader *)imageLoader { + RCTLogWarn(@"Calling bridge.imageLoader is deprecated and will not work in newer versions of RN. Please update to the" + "moduleForClass API or turboModuleLookupDelegate API."); return [self moduleForClass:[RCTImageLoader class]]; }