From 910a750fbce42808350312dee1f5671e5d3e05b1 Mon Sep 17 00:00:00 2001
From: David Angulo <hello@davidangulo.xyz>
Date: Fri, 9 Dec 2022 12:56:07 -0800
Subject: [PATCH] Rename `POST_NOTIFICATION` to `POST_NOTIFICATIONS` (#35533)

Summary:
After adding `<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>` on my `AndroidManifest.xml`, I expected to use `PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS` but `POST_NOTIFICATIONS` is `undefined` and is named `POST_NOTIFICATION` instead.

Every other Android permission is 1:1 in spelling except this one where it lacks `S`.

Not sure if this is a welcome change since this can be breaking. Or maybe we can include both with and without `S` to not be a breaking change. Or just keep it as is and close this PR.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Android] [Changed] - Rename `POST_NOTIFICATION` to `POST_NOTIFICATIONS`

Pull Request resolved: https://github.com/facebook/react-native/pull/35533

Test Plan: `PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS` should not be `undefined`.

Reviewed By: cortinico

Differential Revision: D41705866

Pulled By: philIip

fbshipit-source-id: a0328b174f0196421565f0cd2b2f1eb509428553
---
 Libraries/PermissionsAndroid/PermissionsAndroid.js        | 6 ++++--
 .../js/examples/PermissionsAndroid/PermissionsExample.js  | 8 ++++----
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/Libraries/PermissionsAndroid/PermissionsAndroid.js b/Libraries/PermissionsAndroid/PermissionsAndroid.js
index 14096da108f70b..094b3ccf9016e6 100644
--- a/Libraries/PermissionsAndroid/PermissionsAndroid.js
+++ b/Libraries/PermissionsAndroid/PermissionsAndroid.js
@@ -75,7 +75,8 @@ const PERMISSIONS = Object.freeze({
   ANSWER_PHONE_CALLS: 'android.permission.ANSWER_PHONE_CALLS',
   READ_PHONE_NUMBERS: 'android.permission.READ_PHONE_NUMBERS',
   UWB_RANGING: 'android.permission.UWB_RANGING',
-  POST_NOTIFICATION: 'android.permission.POST_NOTIFICATIONS',
+  POST_NOTIFICATION: 'android.permission.POST_NOTIFICATIONS', // Remove in 0.72
+  POST_NOTIFICATIONS: 'android.permission.POST_NOTIFICATIONS',
   NEARBY_WIFI_DEVICES: 'android.permission.NEARBY_WIFI_DEVICES',
 });
 
@@ -106,7 +107,8 @@ class PermissionsAndroid {
     CAMERA: string,
     GET_ACCOUNTS: string,
     NEARBY_WIFI_DEVICES: string,
-    POST_NOTIFICATION: string,
+    POST_NOTIFICATION: string, // Remove in 0.72
+    POST_NOTIFICATIONS: string,
     PROCESS_OUTGOING_CALLS: string,
     READ_CALENDAR: string,
     READ_CALL_LOG: string,
diff --git a/packages/rn-tester/js/examples/PermissionsAndroid/PermissionsExample.js b/packages/rn-tester/js/examples/PermissionsAndroid/PermissionsExample.js
index d3abbdf140ae9a..cd7f3035f93e9c 100644
--- a/packages/rn-tester/js/examples/PermissionsAndroid/PermissionsExample.js
+++ b/packages/rn-tester/js/examples/PermissionsAndroid/PermissionsExample.js
@@ -83,13 +83,13 @@ function PermissionsExample() {
             style={styles.option}
           />
           <RNTOption
-            label={PermissionsAndroid.PERMISSIONS.POST_NOTIFICATION}
-            key={PermissionsAndroid.PERMISSIONS.POST_NOTIFICATION}
+            label={PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS}
+            key={PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS}
             onPress={() =>
-              setPermission(PermissionsAndroid.PERMISSIONS.POST_NOTIFICATION)
+              setPermission(PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS)
             }
             selected={
-              permission === PermissionsAndroid.PERMISSIONS.POST_NOTIFICATION
+              permission === PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS
             }
             style={styles.option}
           />