From 91fe3b484b8e0807e4edaaa6ed4bb5c2f540e9fd Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 9 Feb 2024 18:27:03 -0800 Subject: [PATCH] Fully rollout FabricSharedEventPipeline (#42949) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42949 Reviewed By: javache, sammy-SC Differential Revision: D53552253 fbshipit-source-id: 67e9db9bd48dd9c37a78e74faf0406fef0c3ad8d --- packages/react-native/ReactAndroid/api/ReactAndroid.api | 1 - .../java/com/facebook/react/config/ReactFeatureFlags.java | 3 --- .../java/com/facebook/react/fabric/FabricUIManager.java | 7 +------ 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 10f5f881f8ad1b..d598d096eeebe5 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -1896,7 +1896,6 @@ public class com/facebook/react/config/ReactFeatureFlags { public static field enableFabricPendingEventQueue Z public static field enableFabricRenderer Z public static field enableFabricRendererExclusively Z - public static field enableFabricSharedEventPipeline Z public static field enableMountHooks Z public static field enableOnDemandReactChoreographer Z public static field enableRemoveDeleteTreeInstruction Z diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java index 6b600a7b7f6dc5..57faf8d7abff2d 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java @@ -115,9 +115,6 @@ public class ReactFeatureFlags { /** Use native view configs in bridgeless mode. */ public static boolean useNativeViewConfigsInBridgelessMode = false; - /** Utilize shared Event C++ pipeline with fabric's renderer */ - public static boolean enableFabricSharedEventPipeline = true; - /** When enabled, Fabric will avoid cloning notes to perform state progression. */ public static boolean enableClonelessStateProgression = false; diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java index 525f8ff3473269..26c832c73660db 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java @@ -80,7 +80,6 @@ import com.facebook.react.uimanager.events.BatchEventDispatchedListener; import com.facebook.react.uimanager.events.EventCategoryDef; import com.facebook.react.uimanager.events.EventDispatcher; -import com.facebook.react.uimanager.events.EventDispatcherImpl; import com.facebook.react.uimanager.events.FabricEventDispatcher; import com.facebook.react.uimanager.events.RCTEventEmitter; import com.facebook.react.views.text.TextLayoutManager; @@ -219,11 +218,7 @@ public FabricUIManager( mMountingManager = new MountingManager(viewManagerRegistry, mMountItemExecutor); mMountItemDispatcher = new MountItemDispatcher(mMountingManager, new MountItemDispatchListener()); - if (ReactFeatureFlags.enableFabricSharedEventPipeline) { - mEventDispatcher = new FabricEventDispatcher(reactContext); - } else { - mEventDispatcher = new EventDispatcherImpl(reactContext); - } + mEventDispatcher = new FabricEventDispatcher(reactContext); mBatchEventDispatchedListener = batchEventDispatchedListener; mReactApplicationContext.addLifecycleEventListener(this);