From df19e597e3e8be9c76f6dba885fd978095710f49 Mon Sep 17 00:00:00 2001
From: Alex Hunt <huntie@meta.com>
Date: Fri, 7 Jun 2024 08:23:45 -0700
Subject: [PATCH] Remove faviconUrl field from CDP list response (#44834)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/44834

- Remove the nonstandard, unused `faviconUrl` field from CDP `/json` response targets (note: both legacy and modern targets).
- Reorder `PageDescription` members.

Changelog:
[General][Removed] - `react-native/dev-middleware`: Remove nonstandard `faviconUrl` field from CDP `/json` response

Reviewed By: hoxyq

Differential Revision: D58092090

fbshipit-source-id: a593be00464853a3fe179305efae5643d616573b
---
 .../src/__tests__/InspectorProxyHttpApi-test.js        |  2 --
 .../src/inspector-proxy/InspectorProxy.js              |  5 ++---
 packages/dev-middleware/src/inspector-proxy/types.js   | 10 ++++++----
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/packages/dev-middleware/src/__tests__/InspectorProxyHttpApi-test.js b/packages/dev-middleware/src/__tests__/InspectorProxyHttpApi-test.js
index 0baa42ccbb0b25..2b7a1e710c7ce2 100644
--- a/packages/dev-middleware/src/__tests__/InspectorProxyHttpApi-test.js
+++ b/packages/dev-middleware/src/__tests__/InspectorProxyHttpApi-test.js
@@ -188,7 +188,6 @@ describe('inspector proxy HTTP API', () => {
             description: 'bar-app',
             deviceName: 'foo',
             devtoolsFrontendUrl: expect.any(String),
-            faviconUrl: 'https://reactjs.org/favicon.ico',
             id: 'device1-page1',
             reactNative: {
               capabilities: {},
@@ -203,7 +202,6 @@ describe('inspector proxy HTTP API', () => {
             description: 'bar-app',
             deviceName: 'foo',
             devtoolsFrontendUrl: expect.any(String),
-            faviconUrl: 'https://reactjs.org/favicon.ico',
             id: 'device2-page1',
             reactNative: {
               capabilities: {},
diff --git a/packages/dev-middleware/src/inspector-proxy/InspectorProxy.js b/packages/dev-middleware/src/inspector-proxy/InspectorProxy.js
index 6df32d2ea5acff..4cde8e9172f254 100644
--- a/packages/dev-middleware/src/inspector-proxy/InspectorProxy.js
+++ b/packages/dev-middleware/src/inspector-proxy/InspectorProxy.js
@@ -155,11 +155,10 @@ export default class InspectorProxy implements InspectorProxyQueries {
 
     return {
       id: `${deviceId}-${page.id}`,
-      description: page.app,
       title: page.title,
-      faviconUrl: 'https://reactjs.org/favicon.ico',
-      devtoolsFrontendUrl,
+      description: page.app,
       type: 'node',
+      devtoolsFrontendUrl,
       webSocketDebuggerUrl,
       vm: page.vm,
       deviceName: device.getName(),
diff --git a/packages/dev-middleware/src/inspector-proxy/types.js b/packages/dev-middleware/src/inspector-proxy/types.js
index ed37c285fc5aa0..bcfba57fa962b0 100644
--- a/packages/dev-middleware/src/inspector-proxy/types.js
+++ b/packages/dev-middleware/src/inspector-proxy/types.js
@@ -108,15 +108,17 @@ export type MessageToDevice =
 // Page description object that is sent in response to /json HTTP request from debugger.
 export type PageDescription = $ReadOnly<{
   id: string,
-  description: string,
   title: string,
-  faviconUrl: string,
-  devtoolsFrontendUrl: string,
+  description: string,
   type: string,
+  devtoolsFrontendUrl: string,
   webSocketDebuggerUrl: string,
+
+  // React Native specific fields
   deviceName: string,
   vm: string,
-  // Metadata specific to React Native
+
+  // React Native specific metadata
   reactNative: $ReadOnly<{
     logicalDeviceId: string,
     capabilities: Page['capabilities'],