From 4e8121a75ec7fa838fc781cbab418d40218678a9 Mon Sep 17 00:00:00 2001 From: Jan Kassens Date: Wed, 3 Apr 2024 09:10:00 -0400 Subject: [PATCH] Remove @providesModule remnants (#28720) Remove @providesModule remnants Removes `@providesModule` from the generated RN modules and CI validation that no `@providesModule` is added which should no longer be needed as this has been the case for years now. --- .circleci/config.yml | 1 - scripts/circleci/check_modules.sh | 17 ----------------- scripts/rollup/wrappers.js | 3 --- 3 files changed, 21 deletions(-) delete mode 100755 scripts/circleci/check_modules.sh diff --git a/.circleci/config.yml b/.circleci/config.yml index f2c743e4525cf..a247a7aceff41 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -84,7 +84,6 @@ jobs: - run: node ./scripts/prettier/index - run: node ./scripts/tasks/eslint - run: ./scripts/circleci/check_license.sh - - run: ./scripts/circleci/check_modules.sh - run: ./scripts/circleci/test_print_warnings.sh yarn_flow: diff --git a/scripts/circleci/check_modules.sh b/scripts/circleci/check_modules.sh deleted file mode 100755 index b9ee63b6eea79..0000000000000 --- a/scripts/circleci/check_modules.sh +++ /dev/null @@ -1,17 +0,0 @@ -#!/bin/bash - -set -e - -# Make sure we don't introduce accidental @providesModule annotations. -EXPECTED='scripts/rollup/wrappers.js' -ACTUAL=$(git grep -l @providesModule -- './*.js' ':!scripts/rollup/shims/*.js') - -# Colors -red=$'\e[1;31m' -end=$'\e[0m' - -if [ "$EXPECTED" != "$ACTUAL" ]; then - printf "%s\n" "${red}ERROR: @providesModule crept into some new files?${end}" - diff -u <(echo "$EXPECTED") <(echo "$ACTUAL") || true - exit 1 -fi diff --git a/scripts/rollup/wrappers.js b/scripts/rollup/wrappers.js index f8202d8ad9a6c..8c13b8eb3c404 100644 --- a/scripts/rollup/wrappers.js +++ b/scripts/rollup/wrappers.js @@ -406,7 +406,6 @@ ${license} * * @noflow * @nolint - * @providesModule ${globalName}-dev * @preventMunge * ${getSigningToken()} */ @@ -421,7 +420,6 @@ ${license} * * @noflow * @nolint - * @providesModule ${globalName}-prod * @preventMunge * ${getSigningToken()} */ @@ -436,7 +434,6 @@ ${license} * * @noflow * @nolint - * @providesModule ${globalName}-profiling * @preventMunge * ${getSigningToken()} */