From 98b8359f656ef714cc44828d7bfd2409ca16b9b3 Mon Sep 17 00:00:00 2001 From: Ricky Date: Fri, 23 Feb 2024 10:31:01 -0500 Subject: [PATCH] [RN] Move unifiedSyncLane back to dynamic (#28430) This surfaced a bug because it wasn't on everywhere, moving back to dynamic while we investigate the bug --- packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js | 1 + packages/shared/forks/ReactFeatureFlags.native-fb.js | 2 +- scripts/flow/xplat.js | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js b/packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js index ccaa927e65c57..d8228bc421487 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js @@ -26,6 +26,7 @@ export const enableDeferRootSchedulingToMicrotask = __VARIANT__; export const enableUseRefAccessWarning = __VARIANT__; export const passChildrenWhenCloningPersistedNodes = __VARIANT__; export const useMicrotasksForSchedulingInFabric = __VARIANT__; +export const enableUnifiedSyncLane = __VARIANT__; // Flow magic to verify the exports of this file match the original version. ((((null: any): ExportsType): DynamicFlagsType): ExportsType); diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js index 42d7a0bbcf992..20b4ba6342f1f 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb.js @@ -24,6 +24,7 @@ export const { enableUseRefAccessWarning, passChildrenWhenCloningPersistedNodes, useMicrotasksForSchedulingInFabric, + enableUnifiedSyncLane, } = dynamicFlags; // The rest of the flags are static for better dead code elimination. @@ -51,7 +52,6 @@ export const disableInputAttributeSyncing = false; export const disableIEWorkarounds = true; export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__; export const enableScopeAPI = false; -export const enableUnifiedSyncLane = true; export const enableCreateEventHandleAPI = false; export const enableSuspenseCallback = false; export const disableLegacyContext = false; diff --git a/scripts/flow/xplat.js b/scripts/flow/xplat.js index 33d061083985c..cc5bc16b82cc5 100644 --- a/scripts/flow/xplat.js +++ b/scripts/flow/xplat.js @@ -14,4 +14,5 @@ declare module 'ReactNativeInternalFeatureFlags' { declare export var enableUseRefAccessWarning: boolean; declare export var passChildrenWhenCloningPersistedNodes: boolean; declare export var useMicrotasksForSchedulingInFabric: boolean; + declare export var enableUnifiedSyncLane: boolean; }