Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https support to standalone DevTools #19111

Closed
NE-SmallTown opened this issue Jun 10, 2020 · 6 comments
Closed

Add https support to standalone DevTools #19111

NE-SmallTown opened this issue Jun 10, 2020 · 6 comments

Comments

@NE-SmallTown
Copy link
Contributor

I notice that the standalone react-devtools use http instead https like "<script src="http://192.1.2.3:8097"></script>" (src code),but my website is always https, so it will get broken because I cant change it to http if it's in iframe(it's diffcult to change the host environment/website protocol).

I'm not familar with the react-devtools implementations, maybe something cause it can only use http to open the server, happy to hear the details, thanks!

React-devtools: 3.6.3

@kunukn
Copy link
Contributor

kunukn commented Jun 11, 2020

It might be because a http server is used?
https://github.com/facebook/react/blob/master/packages/react-devtools-core/src/standalone.js#L246

There is the possibility to use the https server variant, but you need some certificate setup and such.
https://nodejs.org/api/https.html#https_https_createserver_options_requestlistener

@NE-SmallTown
Copy link
Contributor Author

Yea, I think certificate is not a problem because we can do something like https://webpack.js.org/configuration/dev-server/#devserverhttps

@NE-SmallTown
Copy link
Contributor Author

@bvaughn @gaearon friendly ping~ If you don't mind I am not familar with devtools's code, I could try to work on this

@bvaughn
Copy link
Contributor

bvaughn commented Jun 16, 2020

Feel free. Haven't thought about this enough to have an opinion yet.

@bvaughn bvaughn changed the title [Feature Request]Support https in standalone react-devtools Add https support to standalone DevTools Jun 16, 2020
@bvaughn bvaughn closed this as completed Jul 6, 2020
@bvaughn
Copy link
Contributor

bvaughn commented Jul 6, 2020

#19191

@NE-SmallTown
Copy link
Contributor Author

Sorry Brian, these days are too busy, I did some work on NE-SmallTown@cebb026 but have not enough time to do more verification, add docs and add tests, so I have to left it there. Sorry agign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants