From 54f8d04493c19a8016332472699e86754fc0a85d Mon Sep 17 00:00:00 2001 From: Jay Huh Date: Thu, 29 Aug 2024 16:35:30 -0700 Subject: [PATCH] Remove deprecated ones completely --- include/rocksdb/options.h | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/include/rocksdb/options.h b/include/rocksdb/options.h index dfdf315dc87..569045c35fd 100644 --- a/include/rocksdb/options.h +++ b/include/rocksdb/options.h @@ -2283,24 +2283,9 @@ struct SizeApproximationOptions { }; struct CompactionServiceOptionsOverride { - // Currently pointer configurations are not passed to compaction service - // compaction so the user needs to set it. It will be removed once pointer - // configuration passing is supported. Env* env = Env::Default(); std::shared_ptr file_checksum_gen_factory = nullptr; - // DEPRECATED - CFOption pointer configurations will be passed as static name - // These will need to be registered in the remote worker's ObjectRegistry, - // then created by Type::CreateFromString() when needed. - const Comparator* comparator = BytewiseComparator(); - std::shared_ptr merge_operator = nullptr; - const CompactionFilter* compaction_filter = nullptr; - std::shared_ptr compaction_filter_factory = nullptr; - std::shared_ptr prefix_extractor = nullptr; - std::shared_ptr table_factory; - std::shared_ptr sst_partitioner_factory = nullptr; - // END of deprecation marker - // Only subsets of events are triggered in remote compaction worker, like: // `OnTableFileCreated`, `OnTableFileCreationStarted`, // `ShouldBeNotifiedOnFileIO` `OnSubcompactionBegin`,