Skip to content

Commit

Permalink
Fix Python test running under the JIT with ASAN
Browse files Browse the repository at this point in the history
Summary:
The CinderX test runner redirects ASAN output to separate files
by calling the `__sanitizer_set_report_fd` function using ctypes
(https://fburl.com/code/rrbaqnt4). Under the hood, ctypes tries
to resolve `__sanitizer_set_report_fd` using `dlsym`. Resolving
`__sanitizer_set_report_fd` is currently failing (e.g. https://fburl.com/sandcastle/41sbdpx9)
because the symbol is defined but not exported from libpython. This causes
100% of tests to fail because the worker crashes before it can
even run the test. Export the symbol.

Reviewed By: alexmalyshev

Differential Revision: D61686959

fbshipit-source-id: 533e367e7e6491f168e0833f63b04ef811c83b5c
  • Loading branch information
mpage authored and facebook-github-bot committed Aug 26, 2024
1 parent ade16bb commit a91cb3b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions capi-functions
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,7 @@
builtin_next;
_pydict_global_version;
strictmodule_is_unassigned;
/* CinderX's test runner uses this to redirect ASAN output */
__sanitizer_set_report_fd;
};
};

0 comments on commit a91cb3b

Please sign in to comment.