Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comparisons on full #1449

Merged
merged 3 commits into from
Jun 24, 2022
Merged

comparisons on full #1449

merged 3 commits into from
Jun 24, 2022

Conversation

teytaud
Copy link
Contributor

@teytaud teytaud commented May 24, 2022

We prefer to compare on complete experimental results only.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

We prefer to compare on complete experimental results only.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 24, 2022
@teytaud teytaud requested a review from jrapin June 2, 2022 19:46
@teytaud teytaud merged commit 2a7597b into main Jun 24, 2022
@teytaud teytaud deleted the compafull branch June 24, 2022 09:53
teytaud added a commit that referenced this pull request Aug 8, 2022
* comparisons on full

We prefer to compare on complete experimental results only.

* Update plotting.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants