Existing record attributes get set to empty upon a record change.

[VNRARA]

Existing record attributes are removed when records are updated. I'd like it not to.

[favonia]

@VNRARA Thanks for the reporting and sorry for the trouble. It was designed not to do this. I need more information to track down the bug (if any). Which attributes were removed? What are the log and configuration (but remember to remove sensitive content such as your API tokens)?

[VNRARA]

It's about this ones: https://developers.cloudflare.com/dns/manage-dns-records/reference/record-attributes/

logDDNSCF.txt

[favonia]

@VNRARA Thank you. A proper fix needs the upstream to change their code and I have created an issue at cloudflare/cloudflare-go#1371. I can also implement a hack that retrieves your existing comment before updating it, and maybe I will release a new version with the hack soon. Or, you can use version 1.8.2 or below before the upstream library introduced the current behavior.

Some background: I have noticed this design issue of the upstream library some time ago but didn't double check their final solution after getting busy at my primary job. It seems the design bug of the upstream library started to cause clearing (what you observed) at the version 0.60.0, and that means the updater of versions after 1.8.3 were all affected. Sorry about the trouble.

[VNRARA]

I'll keep using the latest version and fix the comments some later time.

[favonia]

@VNRARA I tried to implement the hack and it messed up the current test cases a bit. I prefer to wait for the upstream to fix it, but I will implement the hack (with appropriate testing) if the upstream decides not to do anything.

[favonia]

@VNRARA Progress: I made a PR to the upstream repo: cloudflare/cloudflare-go#1393. Ideally the DNS updater does not have to change if this PR is merged.

[favonia]

@VNRARA Progress: my PR was merged, and I'll release a new version once the dependency is updated.

[favonia]

@VNRARA I believe the bug was fixed. Before I release the next official version, could you confirm that the edge tag will preserve existing tags and comment when updating the IP? Thank you.

[VNRARA]

Hey thanks for keeping me up to date. I'm unsure what how you'd like me to test the edge tag.

[favonia]

@VNRARA The current installation guide told you to use the image favonia/cloudflare-ddns:latest. You can try the next version to be released by temporarily using favonia/cloudflare-ddns:edge instead. Try intentionally change the IP and the tags and/or comments and see if the IP can be updated while keeping others intact. Remember to change edge back to latest after the experiment because the edge version is for me to try out new stuff.

[VNRARA]

I'll try to report back withing 8 hours.

[VNRARA]

Srry for being late: It seems to work fine.

[favonia]

@VNRARA Thanks for the confirmation.

[favonia]

@VNRARA The new version with the fix has been published. It is recommended to switch back to latest because edge is for me to try out new things.