Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new %pypi_source macro for Source URL #172

Closed
hroncok opened this issue Jun 23, 2018 · 3 comments
Closed

Use the new %pypi_source macro for Source URL #172

hroncok opened this issue Jun 23, 2018 · 3 comments

Comments

@hroncok
Copy link
Member

hroncok commented Jun 23, 2018

See: https://pagure.io/packaging-committee/issue/759#comment-517444

Example:

%global pypi_name Jinja2

Name:           python-%{pypi_name}
Version:        2.8
...

Source0:        %pypi_source
@gordonmessmer
Copy link
Member

Is that just a matter of replacing the Source0 line in some of the templates, or are there conditions under which %pypi_source wouldn't be correct for some packages on a platform that provides that macro?

It seems like we might want to check the URL extracted in pypi_metadata_extension to see if it ends in tar.gz and provide the macro alone if it matches, and the macro with arguments if it doesn't.

@hroncok
Copy link
Member Author

hroncok commented Jul 27, 2019

Is that just a matter of replacing the Source0 line in some of the templates

I think so, yes.

Also, we should only do this if it actually matches a pattern. That is not always true for packages with non-canonical names (such as dashes vs. underscores).

@gordonmessmer
Copy link
Member

Resolved in v3.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants