Feat: optional indexing and caching of site.pages
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2022
Closed
radu-matei
approved these changes
Aug 12, 2022
src/template.rs
Outdated
| @@ -20,6 +20,7 @@ pub struct SiteInfo { | |||
| pub base_url: Option<String>, | |||
| pub about: Option<String>, | |||
| pub theme: Option<String>, | |||
| index_site_pages: Option<Vec<String>>, | |||
There was a problem hiding this comment.
I think this should be a public field as well.
src/template.rs
Outdated
| @@ -186,7 +194,12 @@ impl<'a> Renderer<'a> { | |||
| // 3. ??? | |||
| // 4. Leave it like it is | |||
| // 5. Determine that this is out of scope | |||
| pages: crate::content::all_pages(self.content_dir.clone(), self.show_unpublished)?, | |||
| pages: match index_site_page { | |||
There was a problem hiding this comment.
I think an if/else statement here might make it simpler.
src/template.rs
Outdated
| @@ -171,6 +174,11 @@ impl<'a> Renderer<'a> { | |||
| request_headers.insert(String::from(key.as_str()), String::from(val)); | |||
| } | |||
|
|
|||
| let index_site_page: bool = match &info.index_site_pages { | |||
There was a problem hiding this comment.
This could probably be a single match statement below instead.
karthik2804
force-pushed
the
feat/rendering-performance
branch
3 times, most recently
from
9f3068a
to
384e80a
Compare
vdice
reviewed
Aug 15, 2022
Signed-off-by: Karthik Ganeshram <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
feat/rendering-performance
branch
from
384e80a
to
4cf0eec
Compare
vdice
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Performance improvements look great! It looks like @radu-matei's feedback has been addressed. LGTM.
Let's remember to point this breaking change out in the forthcoming release notes....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change with a change required in
site.tomlto fix.Initial implementation of having the ability to index content for
site.pagesfor only required templates. Implement the cache proposed in #15 forsite.pagesto improve performance.Optional indexing improves the performance of pages that do not depend on
site.tomlwhile caching improves the performance of any that uses it.The templates for which
site.pageslist is required can be specified insite.tomlasTODO: Docs.
Some initial performance results for tests on fermyon.com
Optional indexing
This branch
main branch
Caching
site.pagesThis branch
main branch
Note: To test locally on fermyon.com add the following to
site.tomlwhen usingbartholomew.wasmmodule from this branch to test caching with either homepage or blog page.