Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding content for the "Contributing to Bartholomew" page #84

Merged
merged 6 commits into from
Jul 14, 2022
Merged

Adding content for the "Contributing to Bartholomew" page #84

merged 6 commits into from
Jul 14, 2022

Conversation

tpmccallum
Copy link
Contributor

Screen Shot 2022-07-14 at 2 00 18 pm

Signed-off-by: tpmccallum <mistermac2008@gmail.com>
Signed-off-by: tpmccallum <mistermac2008@gmail.com>
Signed-off-by: tpmccallum <mistermac2008@gmail.com>
Signed-off-by: tpmccallum <mistermac2008@gmail.com>
Signed-off-by: tpmccallum <mistermac2008@gmail.com>

## Add changes

Move to a top level directory, underwhich your changes exist i.e. `cd ~/my_bartholomew_contribution/bartholomew`.
Copy link
Collaborator

@technosophos technosophos Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total nit: US English almost always splits this.

Suggested change
Move to a top level directory, underwhich your changes exist i.e. `cd ~/my_bartholomew_contribution/bartholomew`.
Move to a top level directory, under which your changes exist i.e. `cd ~/my_bartholomew_contribution/bartholomew`.

Copy link
Collaborator

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left only one tiny nit.

Signed-off-by: tpmccallum <mistermac2008@gmail.com>
@tpmccallum tpmccallum merged commit ee717c3 into fermyon:main Jul 14, 2022
@tpmccallum tpmccallum deleted the my_new_branch branch July 14, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants