-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themeing support #87
Themeing support #87
Conversation
Signed-off-by: karthik2803 <raams.karthik@gmail.com>
Signed-off-by: karthik2803 <raams.karthik@gmail.com>
Besides a sign-off, could you please also sign your commits, please? Thanks! |
Quick question: why are the static files from the docs directory moved to |
They were just moved there to document and test it as a theme. I could move them back to the original location along with the failing test. |
In general, we want to change as few files as necessary as part of a PR. Thanks! |
Signed-off-by: Karthik Ganeshram <kganeshram@ucdavis.edu>
This is super cool! |
Signed-off-by: Karthik Ganeshram <kganeshram@ucdavis.edu>
ed82366
to
be17014
Compare
I was also wondering which section the documentation will follow in the existing documentation so that I can add the proper links to the site to maintain the chaining of secitons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @karthik2804 this is a great contribution to the project! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Just a handful of typo/grammar suggestions. Looks like the bartholomew.wasm file needs to be updated as well after the recent merge. Thank you!
@vdice I will resolve the conflict along with the fixes and push a new commit. I had one question as to where the docs for themes must be listed. The current order of sections is
I am not sure where the "themes" section fits in that order. |
@karthik2804 good question. No strong opinion here; I think the current ordering in this PR of 4. Configuration 5. Themes 6. Scripting (and so on) makes sense. We'll want to update the end sections accordingly, eg update https://github.com/fermyon/bartholomew/blob/main/docs/content/configuration.md?plain=1#L40 to navigate to the new Themes section and then at the end of the Themes doc we can link to the Scripting page. |
Signed-off-by: Karthik Ganeshram <kganeshram@ucdavis.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added ability to add themes by pulling in git submodules to a
themes/
folder as per discussion on #73. The themes can be configured usingconfig/site.toml
. Added documentation as well but would definitely need to be proofread.Any thoughts/suggestions would be appreciated.